Skip to content

feat(service): implement RocksDB as high volume backend - #689

Open
aldy505 wants to merge 7 commits into
mainfrom
aldy505/feat/service/rocksdb-backend
Open

aldy505 wants to merge 7 commits into
mainfrom
aldy505/feat/service/rocksdb-backend

Conversation

@aldy505

@aldy505 aldy505 commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

objectstore-service now implements the tiered-storage high-volume contract (Backend + HighVolumeBackend) over an embedded RocksDB, alongside the BigTable and in-memory implementations. Rows mirror Bigtable's cell model as flat KV cells keyed by storage path plus a two-byte column suffix, with exact point gets only.

Every cell value is framed with an 8-byte deadline prefix, which drives a compaction filter that physically drops expired rows without decoding their payloads. A single write lock serializes all mutating read-modify-write sequences while reads use a snapshot, reproducing InMemoryBackend's atomicity so compare-and-write cannot interleave. Change-stream write/update/delete reporting matches BigTableBackend.

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.39416% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.91%. Comparing base (8d1c574) to head (19c2d94).

Files with missing lines Patch % Lines
objectstore-service/src/backend/rocksdb.rs 98.39% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   91.53%   91.91%   +0.37%     
==========================================
  Files         120      121       +1     
  Lines       23684    25054    +1370     
==========================================
+ Hits        21680    23028    +1348     
- Misses       2004     2026      +22     
Components Coverage Δ
Rust Backend 94.47% <98.39%> (+0.29%) ⬆️
Rust Client 88.82% <ø> (ø)
Python Client 91.64% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Changelog Preview

This PR lands in these workspaces:

  • objectstore-server: CalVer
📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features

  • Implement RocksDB as high volume backend by aldy505 in #689

🤖 This preview updates automatically when you update the PR.

@aldy505
aldy505 marked this pull request as ready for review November 15, 2026 06:44
@aldy505
aldy505 requested a review from a team as a code owner November 15, 2026 06:44

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 19c2d94. Configure here.

.write(batch)
.context(ErrorKind::BackendFailure, "writing rocksdb upload marker")?;
Ok(())
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload markers skip change stream

Medium Severity

create_upload_marker and delete_upload_marker never call the change stream, so marker lifetime is invisible to cost tracking. BigTableBackend issues begin_write/commit_write on create and commit_delete on a live delete, which this backend is supposed to match.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 19c2d94. Configure here.

Comment thread objectstore-service/src/backend/mod.rs Resolved
@aldy505
aldy505 added this pull request to stack #797 November 15, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant