Repository navigation
Conversation
Semver Impact of This PRThis PR lands in these workspaces:
📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
==========================================
- Coverage 92.03% 91.53% -0.50%
==========================================
Files 120 120
Lines 23514 23698 +184
==========================================
+ Hits 21640 21691 +51
- Misses 1874 2007 +133
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jan-auer
marked this pull request as ready for review
November 16, 2026 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom metadata keys travel in HTTP header names (
x-snme-<key>), but the Python client sent them as given. A key with a space, a non-ASCII character or an uppercase letter went into the header name unchecked. A%or:in a key was also not escaped.The client now applies explicit key rules before it sends anything:
a-z,0-9and_ - | ~ % $ # + . :.ValueErrornaming the key. This happens input()before any request is sent, on both the regular and the resumable upload path.%is sent as%25and:as%3a.%3aand%3Aboth become:, and%253abecomes the literal%3a. A%that is not followed by two hex digits stays as it is. A key with invalid UTF-8 raisesUnicodeDecodeError.The Rust client and the server follow the same key rules.
Ref FS-599
Changelog Entry
put()raisesValueErrorfor a key that is empty or uses characters other thana-z,0-9and_ - | ~ % $ # + . :.