Skip to content

feat(upload): Resumable Uploads - #6421

Merged
tobias-wilfert merged 29 commits into
masterfrom
tobias-wilfert/feat/resumbale-uploads
Oct 5, 2026
Merged

tobias-wilfert merged 29 commits into
masterfrom
tobias-wilfert/feat/resumbale-uploads

Conversation

@tobias-wilfert

@tobias-wilfert tobias-wilfert commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Second attempt at closing INGEST-974.

The PR is as small as possible with the follow ups collected here INGEST-1239. Ended up taking over parts of #6203.

@tobias-wilfert tobias-wilfert self-assigned this Sep 24, 2026
@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown

INGEST-974

@getsentry getsentry deleted a comment from sentry-warden Bot Sep 24, 2026
@getsentry getsentry deleted a comment from sentry-warden Bot Sep 24, 2026

@jjbayer jjbayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, let me know if you want to sync/pair on any of the FIXMEs.

Comment thread relay-server/src/services/upload.rs Resolved
Comment thread relay-server/src/services/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved

@jjbayer jjbayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I believe we should move the feature check, everything else is mostly nitpicks.

Comment thread relay-server/src/endpoints/common.rs Resolved
Comment thread relay-server/src/utils/tus.rs Resolved
Comment thread relay-server/src/services/upload.rs Resolved
Comment thread relay-server/src/services/upload.rs Resolved
@tobias-wilfert
tobias-wilfert marked this pull request as ready for review September 30, 2026 07:02
@tobias-wilfert
tobias-wilfert requested a review from a team as a code owner September 30, 2026 07:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 553e8fd. Configure here.

Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/services/upload.rs Resolved

@jjbayer jjbayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, one concern about backward compatibility.

Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/services/upload.rs Resolved

@jjbayer jjbayer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify (with an integration test) that existing clients still work when the feature flag is off. Then this should be good to go!

Comment thread relay-server/src/endpoints/upload.rs Resolved
Comment thread relay-server/src/endpoints/upload.rs Resolved
@tobias-wilfert
tobias-wilfert added this pull request to the merge queue Oct 5, 2026
Merged via the queue into master with commit 417cfe9 Oct 5, 2026
35 checks passed
@tobias-wilfert
tobias-wilfert deleted the tobias-wilfert/feat/resumbale-uploads branch October 5, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants