Repository navigation
feat(upload): Resumable Uploads - #6421
Conversation
jjbayer
left a comment
There was a problem hiding this comment.
Looks good so far, let me know if you want to sync/pair on any of the FIXMEs.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
jjbayer
left a comment
There was a problem hiding this comment.
Looks great! I believe we should move the feature check, everything else is mostly nitpicks.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 553e8fd. Configure here.
jjbayer
left a comment
There was a problem hiding this comment.
Mostly nits, one concern about backward compatibility.
jjbayer
left a comment
There was a problem hiding this comment.
Please verify (with an integration test) that existing clients still work when the feature flag is off. Then this should be good to go!

Second attempt at closing INGEST-974.
The PR is as small as possible with the follow ups collected here INGEST-1239. Ended up taking over parts of #6203.