Repository navigation
Conversation
Continue batching after buckets that cannot fit into an empty batch, and stop retrying those buckets in global metrics forwarding. Co-authored-by: Codex <noreply@openai.com>
jjbayer
force-pushed
the
fix/oversized-metric-buckets
branch
from
November 3, 2026 13:36
4ba3599 to
6692437
Compare
jjbayer
marked this pull request as ready for review
November 3, 2026 14:37
Dav1dde
reviewed
Nov 4, 2026
|
|
||
| /// Iterator which slices the source view into segments with an approximate size of `size_in_bytes`. | ||
| /// | ||
| /// Buckets that cannot fit into an empty segment, even after splitting, are skipped. |
Member
There was a problem hiding this comment.
So practically this can only happen if the batch size is really small?
Member
There was a problem hiding this comment.
Was thinking instead of skipping whether we should just include the minimum possible size of the bucket. That silent data loss kinda irks me.
An easier alternative is also to internally clamp the minimum size to a threshold which never runs into that issue.
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_encode_metrics_global_drops_oversized_buckets() { |
Member
Author
There was a problem hiding this comment.
Yeah sorry, should have screened it before opening up the PR for review. Will remove.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue batching after buckets that cannot fit into an empty batch, and stop retrying those buckets in global metrics forwarding.
This was flagged by warden here: #6622 (comment)