Repository navigation
fix: Wrap iframe contentWindow access in try-catch #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,7 @@ | |
| * Browsers sometimes incorrectly escape `@import` on `.cssText` statements. | ||
| * This function tries to correct the escaping. | ||
| * more info: https://bugs.chromium.org/p/chromium/issues/detail?id=1472259 | ||
| * @param cssImportRule | ||
|
Check warning on line 74 in packages/rrweb-snapshot/src/utils.ts
|
||
| * @returns `cssText` with browser inconsistencies fixed, or null if not applicable. | ||
| */ | ||
| export function escapeImportStatement(rule: CSSImportRule): string { | ||
|
|
@@ -496,10 +496,23 @@ | |
| * Get the content document of an iframe. | ||
| * Catching errors is necessary because some older browsers block access to the content document of a sandboxed iframe. | ||
| */ | ||
| export function getIframeContentDocument(iframe?: HTMLIFrameElement) { | ||
| export function getIFrameContentDocument(iframe?: HTMLIFrameElement) { | ||
| try { | ||
| return (iframe as HTMLIFrameElement).contentDocument; | ||
| } catch (e) { | ||
| } catch { | ||
| // noop | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Get the content window of an iframe. | ||
| * Catching errors is necessary because iOS 18.5 Safari WebView throws SecurityError | ||
| * when accessing contentWindow on cross-origin iframes (instead of returning null). | ||
| */ | ||
| export function getIFrameContentWindow(iframe?: HTMLIFrameElement) { | ||
| try { | ||
| return (iframe as HTMLIFrameElement).contentWindow; | ||
| } catch { | ||
| // noop | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.