Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
force-pushed
the
lms/namespace-readmes
branch
from
October 28, 2026 16:19
ede04d2 to
64efbd1
Compare
Lms24
marked this pull request as ready for review
October 28, 2026 16:25
Lms24
requested review from
a team,
alexander-alderman-webb,
cleptric,
giortzisg,
mjq and
nsdeschenes
as code owners
October 28, 2026 16:25
alexander-alderman-webb
approved these changes
Oct 29, 2026
alexander-alderman-webb
left a comment
Contributor
There was a problem hiding this comment.
Obviously good work!
My main remark is that I feel uneasy that we would have JSON and YAML for various things after this lands. What if we shove JSON instead of YAML into the markdown? Also feel free to ignore me, just what stood out to me.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds descriptions for attribute namespaces (i.e. the first part of an attribute key).
Why? We've had occasions where attributes landed in the wrong namespace or there was a lot of confusion what kind of semantics one namespace covers.
Therefore, this PR adds:
README.mdfile put into the namespace. The frontmatter part is parsed by our docs setup and rendered with specific UI. The free text markdown underneath is also rendered on docs, but keeps the rendered markdown format.Why a readme over JSON?
attribute.schema.jsonfile. So we'd need to build exclusions around some kind of_meta.jsonfile or whatever we call itIf reviewers have opinions or other suggestions (or want to go with the
_meta.jsonidea) that's fine. Happy to change it!