Repository navigation
docs(javascript): Apply httpIntegration option renames - #19548
Merged
Merged
Conversation
JavaScript SDK v11 renamed several httpIntegration options and removed the
deprecated instrumentation.{requestHook,responseHook,applyCustomAttributesOnSpan}
hooks. Update the HTTP integration reference and the session tracking includes so
they no longer document options that were removed.
Also correct three details that were already stale, found while verifying every
option on the page against the SDK source: the spans default, the trace header
behavior of ignoreOutgoingRequests, and the integration summary, which omitted
incoming spans and sessions.
Fixes SDK-1476
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
Priority: Needs Triage
chargome
marked this pull request as ready for review
September 22, 2026 08:47
chargome
marked this pull request as draft
September 22, 2026 08:47
andreiborza
approved these changes
Sep 22, 2026
| _Type: `boolean`_ (Defaults to `true` when tracing is enabled) | ||
|
|
||
| If set to true, spans will be created for outgoing HTTP requests. | ||
| If set to false, no spans will be created for HTTP requests, neither for incoming nor for outgoing ones. Only the Sentry-specific instrumentation for request isolation is applied. |
Member
There was a problem hiding this comment.
q/l: Do we even need to mention the request isolation here? Seems like an implementation detail.
|
|
||
| <Alert level="warning"> | ||
|
|
||
| This option is deprecated and will be removed in the next major version without a replacement. It only has an effect when `traceLifecycle` is set to `'static'`. With span streaming, child spans are sent as they end, before the response status code is known, so spans can't be dropped based on the status code. To keep requests out of Sentry, use [`ignoreIncomingRequests`](#ignoreincomingrequests), `tracesSampler`, or `ignoreSpans` instead. |
Member
There was a problem hiding this comment.
l: Can we also link to tracesSpampler and ignoreSpans headings like we did for ignoreIncomingRequests?
andreiborza
marked this pull request as ready for review
September 22, 2026 13:16
Contributor
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
Drop the request isolation note from the spans option, since that's an implementation detail readers don't need. Link tracesSampler and ignoreSpans from the ignoreStatusCodes deprecation note, so all three suggested alternatives are reachable, matching how ignoreIncomingRequests is already linked. Refs SDK-1476 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Docs still described
httpIntegrationoptions that v11 renamed or removed.trackIncomingRequestsAsSessions→sessions,maxIncomingRequestBodySize→maxRequestBodySize,ignoreIncomingRequestBody→ignoreRequestBody,dropSpansForIncomingRequestStatusCodes→ignoreStatusCodes,incomingRequestSpanHook→onSpanCreatedignoreStatusCodesas deprecated andtraceLifecycle: 'static'onlyinstrumentationhooks withonSpanCreated/outgoingRequestHook, and document the two other outgoing hooksspansdefault,ignoreOutgoingRequeststrace headers, and the introFixes SDK-1476