Repository navigation
fix(dotnet): Clarify that EnableLogs doesn't gate SentrySdk.Logger - #19820
Conversation
Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
|
The plan checks page failures, HTTP 5xx, and client errors on the changed logs pages. An issue escalates when those pages fail or client errors rise. Services: PlanWhat changedReaders of the .NET logs pages now see that EnableLogs only gates logging integrations. Direct SentrySdk.Logger calls always send logs from SDK 6.10.0. This is live after a production deploy of sentry-docs. The pages are RiskA broken include can hide Setup or Options text on those pages. It can also crash the platform selector there. Wrong wording can lead users to skip EnableLogs for logging integrations. Then those integration logs never reach Sentry. Intended effectThis is a docs wording change. Sentry does not record the new sentences. There is no queryable production signal for the intended effect. Report Regression watchWatch the changed .NET logs pages only. Transaction names are
If failure rate or 5xx rises, check client errors on the same URLs. Look for platform selector or code tab failures. Unresolved issues on these URLs were none in the baseline window. Not observableThe live page wording is not in Sentry. Unsampled page volume is not in Sentry. Latency on these pages is not stable. Thirteen sampled spans in 24h showed p95 from 393ms to 11.9s. Do not use that p95 as a regression rule. |
|
Verified in
|
…19820) ## DESCRIBE YOUR PR The .NET logs docs say `EnableLogs = true` is required to use the `SentrySdk.Logger` APIs. That stopped being true in 6.10.0 ([getsentry/sentry-dotnet#5512](getsentry/sentry-dotnet#5512)). The option now only controls logs captured by the logging integrations (`Microsoft.Extensions.Logging`, Serilog, NLog, log4net). Logs created directly through `SentrySdk.Logger` "are always sent" ([`SentryOptions.cs` L610–620 @ 6.12.0](https://github.com/getsentry/sentry-dotnet/blob/6.12.0/src/Sentry/SentryOptions.cs#L610-L620)). This removes the claim everywhere it appears in the .NET logs docs: - **Options:** the plain .NET `EnableLogs` description now says it controls integration-captured logs, not `SentrySdk.Logger`. - **Options:** the `Microsoft.Extensions.Logging` filter note no longer says `EnableLogs = true` "keeps the `SentrySdk.Logger` APIs available." - **Setup:** the intro explains that `SentrySdk.Logger` needs no extra configuration, and integrations need `EnableLogs = true`. - **Setup (plain .NET):** the `SentrySdk.Init` snippet no longer sets `EnableLogs`, and the note says you only need it with a logging integration. - **Setup (ASP.NET Core, AWS Lambda, Azure Functions, Blazor, MAUI):** the note no longer says `EnableLogs` enables `SentrySdk.Logger`; it enables the `Microsoft.Extensions.Logging` integration. - **Usage:** the intro no longer says the feature must be enabled before using `SentrySdk.Logger`. Integration-based setup snippets still set `EnableLogs = true`, since every integration path still requires it. ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) <!-- junior-request-attribution:start --> via Junior system actor `event`. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent-dispatch%3Adispatch_629c1689a0364da29b4e432b70cfeadb --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/agent-dispatch%3Adispatch_629c1689a0364da29b4e432b70cfeadb) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent-dispatch%3Adispatch_629c1689a0364da29b4e432b70cfeadb/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ricardo Oliveira <ricardo.oliveira@sentry.io>
DESCRIBE YOUR PR
The .NET logs docs say
EnableLogs = trueis required to use theSentrySdk.LoggerAPIs. That stopped being true in 6.10.0 (getsentry/sentry-dotnet#5512). The option now only controls logs captured by the logging integrations (Microsoft.Extensions.Logging, Serilog, NLog, log4net). Logs created directly throughSentrySdk.Logger"are always sent" (SentryOptions.csL610–620 @ 6.12.0).This removes the claim everywhere it appears in the .NET logs docs:
EnableLogsdescription now says it controls integration-captured logs, notSentrySdk.Logger.Microsoft.Extensions.Loggingfilter note no longer saysEnableLogs = true"keeps theSentrySdk.LoggerAPIs available."SentrySdk.Loggerneeds no extra configuration, and integrations needEnableLogs = true.SentrySdk.Initsnippet no longer setsEnableLogs, and the note says you only need it with a logging integration.EnableLogsenablesSentrySdk.Logger; it enables theMicrosoft.Extensions.Loggingintegration.SentrySdk.Logger.Integration-based setup snippets still set
EnableLogs = true, since every integration path still requires it.IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via Junior system actor
event.--
View Junior Session [Sentry]