Repository navigation
Collapse Envelope.FromTransaction overloads into a single method with optional parameters #5397
Description
Background
Follow-up from #5182 (review).
Envelope.FromTransaction is currently split into two overloads:
public static Envelope FromTransaction(SentryTransaction transaction) =>
FromTransaction(transaction, null, null);
public static Envelope FromTransaction(
SentryTransaction transaction,
IDiagnosticLogger? logger,
IReadOnlyCollection<SentryAttachment>? attachments)The sibling factory methods FromEvent and FromFeedback instead expose a single method with optional parameters defaulting to null:
public static Envelope FromFeedback(
SentryEvent @event,
IDiagnosticLogger? logger = null,
IReadOnlyCollection<SentryAttachment>? attachments = null,
SessionUpdate? sessionUpdate = null)As @bitsandfoxes noted, collapsing FromTransaction into a single method with optional parameters would bring it in line with the rest.
Proposal
Replace the two FromTransaction overloads with a single method:
public static Envelope FromTransaction(
SentryTransaction transaction,
IDiagnosticLogger? logger = null,
IReadOnlyCollection<SentryAttachment>? attachments = null)
Activity
linear-code commentedon Jul 16, 2026
NET-746
refactor!: Collapse Envelope.FromTransaction overloads into one