Repository navigation
Capture data for Mono server side symbolication #579
Description
#578 added parsing of Mono stacktraces. Part of the data it reads can be used to symbolicate frames with pdbs. But until Sentry adds support to it, there's no where to add it to the event.
Platform = "mono", // needs to be agreed with the backend
ModuleVersionId = f.Mvid,
AotId = f.Aotid,
MethodIndex = f.MethodIndex.ToString("x4"),
IsILOffset = f.IsILOffset,
Protocol needs:
/// Module Version Id.
/// </summary>
/// <remarks>Used by the Mono AOT compiler</remarks>
[DataMember(Name = "mvid", EmitDefaultValue = false)]
public string? ModuleVersionId { get; set; }
/// <summary>
/// AOT Id.
/// </summary>
/// <remarks>Used by the Mono AOT compiler</remarks>
[DataMember(Name = "aotid", EmitDefaultValue = false)]
public string? AotId { get; set; }
/// <summary>
/// Method Index.
/// </summary>
/// <remarks>Used by the Mono AOT compiler</remarks>
[DataMember(Name = "method_index", EmitDefaultValue = false)]
public string? MethodIndex { get; set; }
/// <summary>
/// Is IL offset.
/// </summary>
/// <remarks>Used by the Mono AOT compiler</remarks>
[DataMember(Name = "is_il_offset", EmitDefaultValue = false)]
public bool? IsILOffset { get; set; }
Activity
bruno-garcia commentedon Nov 28, 2020
@jan-auer this is what I was referring to in terms of protocol change.
SimonCropp commentedon Jun 30, 2022
related to #1740
mattjohnsonpint commentedon Feb 16, 2023
@bruno-garcia - Was this for a different use case than we implemented recently (with #2050)?
The whole
StackFrameDataclass appears to be unused, BTW.mattjohnsonpint commentedon Feb 16, 2023
However, it is the only place we have an
AotId- so I wonder if that's what we need to help resolve #2180...mattjohnsonpint commentedon Feb 17, 2023
Ok, after diving in further, I'm pretty sure that we can delete
StackFrameDataas dead code. It was used as part ofMonoSentryStackTraceFactory, which was deleted in #2050. Basically, it's just for parsing info from theexception.StackTracestring that mono added when running with-debug(not debug configuration, but the mono debugging flag). We don't need to do that any more, as we have the ppdb support. which gets most of the same data, directly from the symbol files.It doesn't help with #2180, as there is no pre-made
exception.StackTracestring to parse there.mattjohnsonpint commentedon Feb 17, 2023
Closing this issue, as it was handled by #2050 and corresponding Symbolic changes.