Repository navigation
feat!: remove obsolete iOS options EnableAppHangTrackingV2 and AddInAppExclude - #5654
Merged
Merged
Conversation
…nAppExclude Both were marked obsolete when sentry-cocoa v9 made App Hangs V2 the default and dropped inAppExcludes. EnableAppHangTracking stays disabled by default: sentry-cocoa has deprecated App Hang tracking in favour of MetricKit and removes it in v10. Closes #4877 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Native.EnableAppHangTrackingV2 and Native.AddInAppExcludeEnableAppHangTrackingV2, EnableWatchdogTerminationTracking and AddInAppExclude
This was
linked to
issues
Sep 30, 2026
EnableAppHangTrackingV2, EnableWatchdogTerminationTracking and AddInAppExcludeNative.EnableAppHangTrackingV2 and Native.AddInAppExclude
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version7 #5654 +/- ##
===========================================
Coverage ? 75.04%
===========================================
Files ? 516
Lines ? 18931
Branches ? 3677
===========================================
Hits ? 14207
Misses ? 3859
Partials ? 865 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Native.EnableAppHangTrackingV2 and Native.AddInAppExcludeEnableAppHangTrackingV2 and AddInAppExclude
jamescrosswell
marked this pull request as ready for review
October 1, 2026 04:25
ric-oliv
approved these changes
Oct 1, 2026
ric-oliv
left a comment
Member
There was a problem hiding this comment.
Nice... The code looks fine for me.
Interesting that the java and cocoa packages are diverging on this, though.
Maybe worth also mentioning in the PR description
Removed SentryOptions.Native.AddInAppExclude(string) on iOS, which had no effect.
since the Android version is still there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the two Cocoa native options that were marked
[Obsolete]when sentry-cocoa v9 landed in #4830:SentryOptions.Native.EnableAppHangTrackingV2(and its bindable counterpart). App Hangs V2 is whatEnableAppHangTrackingturns on in sentry-cocoa v9, so users should set that instead.SentryOptions.Native.AddInAppExclude(string). It has had no effect since sentry-cocoa v9 removedinAppExcludes.AddInAppIncludeand the AndroidNative.AddInAppExcludeare unchanged.Changelog Entry
SentryOptions.Native.EnableAppHangTrackingV2on iOS and Mac Catalyst (useEnableAppHangTrackinginstead)SentryOptions.Native.AddInAppExclude(string)on iOS, which had no effectEnableAppHangTrackingstaysfalseby defaultThe issue asked us to reconsider this default. I've left it disabled:
CHANGELOG_V10.mdand decision 38 indevelop-docs/DECISIONS.mdin the submodule). Turning it on by default now would opt every .NET iOS app into a feature that's on its way out.Closes #4877
🤖 Generated with Claude Code