Replace SDKs catch (Exception e) to catch (Throwable e) #1806

Activity

1. getsantry

   added

   Status: Untriaged

   on Nov 15, 2021
2. marandaneto

   added

   Status: Backlog

   and removed

   Status: Untriaged

   on Nov 15, 2021
3. philippsuess commented on Nov 17, 2021

   

   philippsuess

   on Nov 17, 2021

   More actions

   Make sure to log out when we swallow a Throwable. We still need to find out how to log out.
4. philippsuess

   assigned

   romtsn

   and

   bruno-garcia

   and unassigned

   romtsn

   on Nov 17, 2021
5. bruno-garcia commented on Nov 18, 2021

   

   bruno-garcia

   on Nov 18, 2021

   Last edited by bruno-garcia

   Member

   More actions

   The PR #1812 partially addresses this. See PR description for details.
   Goal: Changes all Java catch Exception to Throwable so we avoid crashes on Unity that should have been suppressed.

   For this issue I suggest we add a linter. So we avoid adding catch Exception again in the future. The linter should warn that throwable should be used to suppress all errors instead.

   👍React with 👍1Reacted by Manoel Aranda Neto
6. bruno-garcia

   removed their assignment

   on Nov 18, 2021
7. bruno-garcia

   added

   Platform: Java

   on Mar 10, 2022
8. hubertdeng123

   removed

   Status: Backlog

   on Jul 25, 2023
9. romtsn commented on Oct 18, 2023

   

   romtsn

   on Oct 18, 2023

   Contributor

   More actions

   Added an additional point to #2685 to track the lint checks, closing this one
10. romtsn

    closed this as completedon Oct 18, 2023