Skip to content

Deprecate instrumentD1WithSentry and instrument via ENV variables #20862

Closed

Description

@JPeer264

Problem Statement

As of now instrumentD1WithSentry needs to be used every time when env.DB is used. This can now be archived via instrumentEnv.

Also increase support, as now we only instrument prepare statements and nothing else

Solution Brainstorm

We need to be careful about double instrumentation. When enabling D1 support by default via env instrumentation and a user has their D1 manually instrumented, then we shouldn't double wrap. Maybe ensureInstrumented can help out

Additional Context

batch, exec and withSession are not instrumented. dump seems to be deprecated and is only valid for v1 databases, where we anyways don't have support

Priority

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.

Activity

  1. linear-code commented on May 13, 2026

    @linear-code
  2. added this to the 11.0.0 milestone on May 13, 2026
  3. self-assigned this
    on Jun 2, 2026
  4. added a commit that references this issue on Jun 3, 2026
    40b260b
  5. github-actions commented on Jun 9, 2026

    @github-actions
    Contributor

    A PR closing this issue has just been released 🚀

    This issue was referenced by PR #21276, which was included in the 10.57.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions