Repository navigation
chore(ci): Pack tarballs in the build job - #26377
Draft
nicohrubec wants to merge 2 commits into
Draft
nicohrubec wants to merge 2 commits into
nicohrubec wants to merge 2 commits into
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
Contributor
size-limit report 📦Compared: 5446788 (PR test merge using feat/benchmark-e2e-sharding at e20e580) Against: 14e0d56 (feat/benchmark-e2e-sharding) · base run #66054
|
nicohrubec
changed the title
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pack tarballs in the existing Build job.
Why
This eliminates the additional setup overhead from having this in a separate job. The tradeoff is a 10s later Build completion for integration tests, but E2E tarballs become available 40s earlier. This means E2E tests now finish much earlier and the integration tests are the bottleneck again. However, these are much easier to optimize by just throwing more compute at them, which I'll do in a follow up.
Required checks is limited by the integration tests finishing: