[0.17] ref!: sentry_value-based attachments - #1974
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
==========================================
+ Coverage 74.24% 74.60% +0.36%
==========================================
Files 104 104
Lines 26584 26786 +202
Branches 4838 4860 +22
==========================================
+ Hits 19736 19985 +249
+ Misses 5499 5455 -44
+ Partials 1349 1346 -3 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 11, 2026 20:01
4ecd0c8 to
7cfebae
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 12, 2026 06:33
7cfebae to
ed216c7
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 07:51
77576ea to
8349c66
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 09:40
8349c66 to
c7f80db
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 10:37
c7f80db to
b901758
Compare
This was referenced Aug 17, 2026
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
2 times, most recently
from
August 20, 2026 16:26
4677c4e to
4c21efb
Compare
Allow callers with borrowed path strings to obtain the final path component without allocating a sentry_path_t. This prepares value-based attachment properties, which expose borrowed strings.
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 26, 2026 09:09
d521912 to
08e8f8c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 08e8f8c. Configure here.
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
2 times, most recently
from
August 26, 2026 09:52
ef00839 to
bb5f6d7
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 26, 2026 10:03
bb5f6d7 to
c5b45c3
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 26, 2026 12:55
c5b45c3 to
20c5112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Caution
BREAKING CHANGE
Attachment APIs now use
sentry_value_tandsentry_uuid_tinstead ofsentry_attachment_t *.Scope data is moving to fine-grained read/write locking (#1877) to allow concurrent readers. A read-locked getter cannot safely return a borrowed
sentry_attachment_tpointer because a writer may remove and free the attachment as soon as the read lock is released, crashing a potential concurrent reader.Represent attachments and attachment collections as refcounted
sentry_value_tobjects. A getter can retain the value under the read lock and return an owned reference that remains valid after unlocking.Configure attachments before insertion and freeze them once added. Use UUIDs for removal, and retain byte values while envelopes borrow their payload to avoid copying attachment data.
See also:
Resolves: #1945