Skip to content

test(windows): cover invalid-parameter crashes - #2016

Merged
jpnurmi merged 2 commits into
masterfrom
jpnurmi/test/invalid-parameter
Aug 26, 2026
Merged

test(windows): cover invalid-parameter crashes#2016
jpnurmi merged 2 commits into
masterfrom
jpnurmi/test/invalid-parameter

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Both crashpad and native capture invalid-parameter errors via WER:

(.venv) C:\Users\jpnurmi\Projects\sentry\sentry-native>pytest --with_wer -v tests\ -k "invalid-parameter"
=================================================================== test session starts ====================================================================
platform win32 -- Python 3.13.3, pytest-9.0.3, pluggy-1.6.0 -- C:\Users\jpnurmi\Projects\sentry\sentry-native\.venv\Scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\Users\jpnurmi\Projects\sentry\sentry-native
plugins: flaky-3.8.1, pytest_httpserver-1.0.10, xdist-3.8.0
collected 2020 items / 2018 deselected / 2 selected

tests/test_integration_crashpad.py::test_crashpad_wer_crash[invalid-parameter] PASSED                                                                 [ 50%]
tests/test_integration_native.py::test_native_wer_crash[invalid-parameter] PASSED                                                                     [100%]

Close: #327

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (dec0e5e) to head (be10718).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
+ Coverage   74.24%   74.26%   +0.02%     
==========================================
  Files         104      104              
  Lines       26584    26584              
  Branches     4838     4838              
==========================================
+ Hits        19736    19742       +6     
+ Misses       5499     5490       -9     
- Partials     1349     1352       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi marked this pull request as ready for review August 24, 2026 14:43
@jpnurmi
jpnurmi force-pushed the jpnurmi/test/invalid-parameter branch from 8cd9cd6 to a29c35f Compare August 26, 2026 08:44
@jpnurmi
jpnurmi requested a review from limbonaut August 26, 2026 15:21
@jpnurmi
jpnurmi merged commit bb7666a into master Aug 26, 2026
111 of 112 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/test/invalid-parameter branch August 26, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashpad not capturing invalid_parameter errors on Windows

2 participants