Skip to content

chore: Inline span-streaming branch of tracing shims in billing - #124721

Merged
alexander-alderman-webb merged 2 commits into
masterfrom
webb/revenue/remove-tracing-shim
Oct 7, 2026
Merged

alexander-alderman-webb merged 2 commits into
masterfrom
webb/revenue/remove-tracing-shim

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Inline the branches of utils.tracing.start_span(), utils.tracing.trace(), utils.tracing.set_span_tag() and utils.tracing.set_span_data() that run when the streaming trace lifecycle is enabled.

Since edfb641 the streaming trace lifecycle is always enabled.

Add repr() around the second argument to StreamedSpan.set_attribute() when mypy complains. Calling repr() is the existing runtime fallback in the SDK.

Set attributes in the attributes parameter to traces.start_span() instead of calling StreamedSpan.set_attribute() where reasonable.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2026
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/revenue/remove-tracing-shim branch from fe14366 to d394ab2 Compare September 18, 2026 07:28
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 18, 2026 09:10
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 18, 2026 09:10
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/revenue/remove-tracing-shim branch from d394ab2 to 2b89c17 Compare September 18, 2026 09:54

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fb78126. Configure here.

@alexander-alderman-webb
alexander-alderman-webb merged commit 493bf34 into master Oct 7, 2026
69 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/revenue/remove-tracing-shim branch October 7, 2026 09:38

This branch was successfully deployed

1 active deployment
Preview — fb78126a Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants