Skip to content

chore: Inline span-streaming branch of tracing shims in security files - #124723

Merged
alexander-alderman-webb merged 3 commits into
masterfrom
webb/security/remove-tracing-shim
Oct 8, 2026
Merged

alexander-alderman-webb merged 3 commits into
masterfrom
webb/security/remove-tracing-shim

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Inline the branches of utils.tracing.start_span(), utils.tracing.trace(), utils.tracing.set_span_tag() and utils.tracing.set_span_data() that run when the streaming trace lifecycle is enabled.

Since edfb641 the streaming trace lifecycle is always enabled.

Add repr() around the second argument to StreamedSpan.set_attribute() when mypy complains. Calling repr() is the existing runtime fallback in the SDK.

Set attributes in the attributes parameter to traces.start_span() instead of calling StreamedSpan.set_attribute() where reasonable.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2026
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/security/remove-tracing-shim branch from c3d7076 to 9b2a73b Compare September 18, 2026 07:09
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 18, 2026 09:30
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 18, 2026 09:30
Comment thread src/sentry/net/socket.py Resolved
@alexander-alderman-webb
alexander-alderman-webb merged commit 0c81614 into master Oct 8, 2026
70 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/security/remove-tracing-shim branch October 8, 2026 16:45

This branch was successfully deployed

1 active deployment
Preview — f4dc08be Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants