Skip to content

feat(explore): Emit json expansion project option into relay config - #126236

Merged
k-fish merged 5 commits into
masterfrom
feat/expandattrs/emit-project-option-into-project-config
Oct 15, 2026
Merged

k-fish merged 5 commits into
masterfrom
feat/expandattrs/emit-project-option-into-project-config

Conversation

@k-fish

@k-fish k-fish commented Oct 1, 2026

Copy link
Copy Markdown
Member

Related to the change here getsentry/relay#6459. Will wait to cut relay + update pyproject toml before landing this.

Closes EXP-1261

Should be fine to emit without cutting, extra options should be ignored.

Closes EXP-1261
@k-fish
k-fish requested a review from a team as a code owner October 1, 2026 20:49
@linear-code

linear-code Bot commented Oct 1, 2026

Copy link
Copy Markdown

EXP-1261

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 1, 2026
Comment on lines +852 to +856
exposed_features = list(get_exposed_features(project))
if project.get_option("sentry:relay_automatic_json_expansion"):
# This is a project option encoded as a feature, not an actual project flag.
exposed_features.append("projects:relay-automatic-json-expansion")
if exposed_features:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could probably write a small FeatureHandler that turns the option into a feature to make this less ad-hoc.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call but I'll probably leave that as an exercise to the reader if anyone ever ends up with this flow again (seems unlikely since this is the first in a very long time)

@k-fish
k-fish merged commit 81905d6 into master Oct 15, 2026
69 checks passed
@k-fish
k-fish deleted the feat/expandattrs/emit-project-option-into-project-config branch October 15, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants