Repository navigation
feat(explore): Emit json expansion project option into relay config - #126236
Merged
k-fish merged 5 commits intoOct 15, 2026
Merged
Conversation
Should be fine to emit without cutting, extra options should be ignored. Closes EXP-1261
Dav1dde
approved these changes
Oct 2, 2026
…project-config Co-authored-by: Cursor <cursoragent@cursor.com>
jjbayer
approved these changes
Oct 13, 2026
Comment on lines
+852
to
+856
| exposed_features = list(get_exposed_features(project)) | ||
| if project.get_option("sentry:relay_automatic_json_expansion"): | ||
| # This is a project option encoded as a feature, not an actual project flag. | ||
| exposed_features.append("projects:relay-automatic-json-expansion") | ||
| if exposed_features: |
Member
There was a problem hiding this comment.
nit: You could probably write a small FeatureHandler that turns the option into a feature to make this less ad-hoc.
Member
Author
There was a problem hiding this comment.
good call but I'll probably leave that as an exercise to the reader if anyone ever ends up with this flow again (seems unlikely since this is the first in a very long time)
k-fish
deleted the
feat/expandattrs/emit-project-option-into-project-config
branch
October 15, 2026 16:10
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the change here getsentry/relay#6459. Will wait to cut relay + update pyproject toml before landing this.
Closes EXP-1261