Repository navigation
test(auth): Cover stale pending invitation sessions - #126496
Merged
evanpurkhiser merged 1 commit intoOct 7, 2026
Merged
Conversation
nora-shap
approved these changes
Oct 5, 2026
evanpurkhiser
enabled auto-merge (squash)
October 5, 2026 19:49
evanpurkhiser
force-pushed
the
git/test-auth-cover-stale-pending-invitation-sessions
branch
from
October 5, 2026 20:08
6564619 to
14a1527
Compare
Contributor
Sentry Snapshot Testing
|
evanpurkhiser
force-pushed
the
git/test-auth-cover-stale-pending-invitation-sessions
branch
from
October 5, 2026 21:49
14a1527 to
16fc891
Compare
Keep stale-session coverage at the invite helper layer after MFA enrollment stopped reading pending invitations from the session.
evanpurkhiser
force-pushed
the
git/test-auth-cover-stale-pending-invitation-sessions
branch
from
October 7, 2026 15:24
16fc891 to
337401e
Compare
evanpurkhiser
deleted the
git/test-auth-cover-stale-pending-invitation-sessions
branch
October 7, 2026 15:35
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MFA enrollment stopped reading pending invitations from the session in #126057, removing the enrollment tests that covered stale sessions. This follow-up exercises
ApiInviteHelper.from_sessiondirectly in the existing helper test suite.The tests cover a deleted invite member returning
Noneand logging "Invalid pending invite cookie", a rotated token failing request validation, and an existing organization member resolving to their own membership. The existing-member case also verifies the "User already org member" log and removal of the stale pending invite while preserving the user's membership.Validation: all 11 tests in
tests/sentry/api/test_invite_helper.pypassed; pre-commit checks passed.