Repository navigation
ref: unify TopBar title slot with breadcrumbs titleItem - #126554
Conversation
|
bugbot run |
Story previewsPreview the stories changed in this PR on the Vercel deployment:
Preview deployment: https://sentry-pwv0ea588.sentry.dev |
|
@priscilawebdev: done 2058e42 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 61f5dec. Configure here.
| <Outlet /> | ||
| </SettingsLayout> | ||
| </BreadcrumbProvider> | ||
| </SettingsBreadcrumbsProvider> |
There was a problem hiding this comment.
Admin pages lose breadcrumb titles
Medium Severity
SettingsBreadcrumbsProvider only supplies parent items; the TopBar heading and trail render only when a page mounts BreadcrumbTitle or SettingsPageHeader. adminLayout switched to that provider, but most /manage/ pages never render either, so those screens lose their heading and breadcrumb trail. Only adminUserEdit opted in.
Reviewed by Cursor Bugbot for commit 61f5dec. Configure here.
Admin `/manage/` pages now show their TopBar title and Settings breadcrumb trail again. #126554 removed the automatic header from `SettingsLayout`, but these pages had no page-owned title.


Admittedly, this PR got away from me. What was meant to be a "simple" unification between the
titleslot an thebreadcrumbsslottitleitem became ... a bit more 😅.The biggest problem was the
settingsdidn’t use ourbreadcrumbsat all - but it does now. The API design forced this move because I wanted thebreadcrumbsslot to be strictly typed, like:with this, every page:
Before this PR, we could pass
children, which could or could not be<BreadCrumbsList>, and a lot of the time, it wasn’t (looking at you,settingsandpreprod).So now it is, with some tradeoffs and changes. I’ve left a bunch of comments on the sections that I think are most relevant to review.
fixes DE-1599