Skip to content

ref: unify TopBar title slot with breadcrumbs titleItem - #126554

Merged
TkDodo merged 54 commits into
masterfrom
tkdodo/ref/de-1599-topbar-breadcrumbs-title
Oct 7, 2026
Merged

TkDodo merged 54 commits into
masterfrom
tkdodo/ref/de-1599-topbar-breadcrumbs-title

Conversation

@TkDodo

@TkDodo TkDodo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Admittedly, this PR got away from me. What was meant to be a "simple" unification between the title slot an the breadcrumbs slot title item became ... a bit more 😅.

The biggest problem was the settings didn’t use our breadcrumbs at all - but it does now. The API design forced this move because I wanted the breadcrumbs slot to be strictly typed, like:

<TopBar.Slot
  name="breadcrumbs"
  title={{type: 'page-title', label: title}}
  items={[...]}
/>

with this, every page:

  • needs a title
  • can potentially have breadcrumbs (items) but they need to be in the correct format / types.

Before this PR, we could pass children, which could or could not be <BreadCrumbsList>, and a lot of the time, it wasn’t (looking at you, settings and preprod).

So now it is, with some tradeoffs and changes. I’ve left a bunch of comments on the sections that I think are most relevant to review.

fixes DE-1599

@TkDodo

TkDodo commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

@linear-code

linear-code Bot commented Oct 6, 2026

Copy link
Copy Markdown

DE-1599

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@TkDodo

TkDodo commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

@priscilawebdev: done 2058e42

@TkDodo
TkDodo marked this pull request as ready for review October 7, 2026 14:17
@TkDodo
TkDodo requested review from a team as code owners October 7, 2026 14:17
@TkDodo
TkDodo requested a review from a team October 7, 2026 14:18
@TkDodo
TkDodo requested review from a team as code owners October 7, 2026 14:18
@TkDodo
TkDodo merged commit 116991b into master Oct 7, 2026
78 of 79 checks passed
@TkDodo
TkDodo deleted the tkdodo/ref/de-1599-topbar-breadcrumbs-title branch October 7, 2026 14:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 61f5dec. Configure here.

<Outlet />
</SettingsLayout>
</BreadcrumbProvider>
</SettingsBreadcrumbsProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin pages lose breadcrumb titles

Medium Severity

SettingsBreadcrumbsProvider only supplies parent items; the TopBar heading and trail render only when a page mounts BreadcrumbTitle or SettingsPageHeader. adminLayout switched to that provider, but most /manage/ pages never render either, so those screens lose their heading and breadcrumb trail. Only adminUserEdit opted in.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 61f5dec. Configure here.

TkDodo added a commit that referenced this pull request Oct 8, 2026
Admin `/manage/` pages now show their TopBar title and Settings
breadcrumb trail again. #126554 removed the automatic header from
`SettingsLayout`, but these pages had no page-owned title.

This branch was successfully deployed

1 active deployment
Preview — 61f5dec4 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants