Repository navigation
test(jest): Share React across automatic mock registries - #126567
Merged
Merged
Conversation
nsdeschenes
marked this pull request as ready for review
October 6, 2026 17:49
TkDodo
approved these changes
Oct 9, 2026
nsdeschenes
added a commit
that referenced
this pull request
Oct 9, 2026
The automock regression added in #126567 uses a native button, increasing the file's `@sentry/scraps/prefer-primitives` violations from three to four and exceeding its lint budget. Use the Scraps `Button` in that regression so lint passes and the query-state interaction stays covered. Validation: - Oxlint passed for all three files from #126567. - Pre-commit checks passed. - All nine `nuqsTestingAdapter` tests passed.
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest evaluates dependencies in a separate module registry while generating automatic mocks. Share the real React instance across those registries so nuqs reuses its adapter context.
Add a regression combining an automatic hook mock with real query-state reads and updates.
Discovered while exploring: #126218