Repository navigation
ref(np): Build Slack metric alert platform data with the shared factory - #126674
Merged
Merged
Conversation
hobzcalvin
marked this pull request as draft
October 6, 2026 23:02
hobzcalvin
marked this pull request as ready for review
October 6, 2026 23:23
shayna-ch
approved these changes
Oct 7, 2026
…he shadow comparison Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
hobzcalvin
force-pushed
the
grant/np-metric-alert-data-factory
branch
from
October 7, 2026 17:06
1292236 to
25ac4ed
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetricAlertNotificationDatawas built in two places:metric_alert_notification_data_factory, used only by the shadow comparison (#125560), and_send_via_notification_platformin the Slack metric alert handler, the real send path for orgs on the platform. The two had drifted: for Slack staging actions the factory builtreferrer=metric_alert_slack_staging, while legacy and the real platform send usemetric_alert_slack. The shadow comparison also checked the factory's output rather than what the platform actually sends.metric_alert_slackfor Slack staging, matching legacy. The shadow test that recorded the referrer difference now expects a match.IssueNotificationContext, and_send_via_notification_platformbuilds its data with it.The real send's payload is unchanged;
test_send_alert_via_np_sends_to_slack_channelnow also checks its referrer.