Repository navigation
feat(auth): Replace branded artwork with animated illustrations - #126709
evanpurkhiser merged 1 commit into
Conversation
2399b27 to
387129d
Compare
387129d to
ec5ef29
Compare
ec5ef29 to
9cae1b7
Compare
📊 Type Coverage Diff
🔍 4 new type safety issues introduced
This is informational only and does not block the PR. |
9cae1b7 to
40ff413
Compare
40ff413 to
73b0159
Compare
73b0159 to
9d233e4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9d233e4. Configure here.
| const hasSideArtwork = useMedia(`(min-width: ${theme.breakpoints.md})`); | ||
| const sources = hasSideArtwork ? DESKTOP_ASSETS : MOBILE_ASSETS; | ||
| const [settledSources, setSettledSources] = useState<ReadonlySet<string>>(new Set()); | ||
| const isLoading = sources.some(src => !settledSources.has(src)); |
There was a problem hiding this comment.
Loader returns after breakpoint change
Medium Severity
isArtworkLoading stays tied to the current viewport asset list, so widening past md after the auth page is already shown makes sources jump to the full desktop set. BrandedAuthLayout treats that as a fresh page load, sets isLoading, and hides the form behind the full-page loader until every side-illustration image decodes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9d233e4. Configure here.
9d233e4 to
4a6a28b
Compare
4a6a28b to
58a7a67
Compare
58a7a67 to
0c4ce27
Compare


Replace the branded auth artwork with the illustrator’s layered animation and add a four-frame critter beneath the login and registration controls. The critter is absolutely positioned against the form’s right edge and does not contribute to page height.
The scene uses transparent AVIF sprite atlases with a Framer Motion entrance, hover reactions, ambient character playback, and independent SVG star twinkles. Playback runs at 2× speed and pauses offscreen and in background tabs, with still frames for reduced motion. Remove the previous illustration renderer and all five of its assets.
Artwork downloads and decoding start alongside authentication data loading. The shared page loader stays visible until both are ready; failed images settle without blocking the page. Mobile preloads the critter and skips the hidden side illustration.
Validation: artwork and login/registration tests pass, including three preload regressions covering decode readiness, image failures, and mobile requests. Repository checks pass. Verified desktop/mobile positioning, unchanged page height, hover playback, reduced motion, and preloaded desktop images in the browser. Full typechecking remains blocked by existing errors in
ansiText.tsxand missingansi-sequence-parser/conduit-clientdependencies.