Skip to content

feat(auth): Replace branded artwork with animated illustrations - #126709

Merged
evanpurkhiser merged 1 commit into
masterfrom
git/feat-auth-replace-branded-artwork-with-animated-illustrations
Oct 7, 2026
Merged

evanpurkhiser merged 1 commit into
masterfrom
git/feat-auth-replace-branded-artwork-with-animated-illustrations

Conversation

@evanpurkhiser

@evanpurkhiser evanpurkhiser commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Replace the branded auth artwork with the illustrator’s layered animation and add a four-frame critter beneath the login and registration controls. The critter is absolutely positioned against the form’s right edge and does not contribute to page height.

The scene uses transparent AVIF sprite atlases with a Framer Motion entrance, hover reactions, ambient character playback, and independent SVG star twinkles. Playback runs at 2× speed and pauses offscreen and in background tabs, with still frames for reduced motion. Remove the previous illustration renderer and all five of its assets.

Artwork downloads and decoding start alongside authentication data loading. The shared page loader stays visible until both are ready; failed images settle without blocking the page. Mobile preloads the critter and skips the hidden side illustration.

Validation: artwork and login/registration tests pass, including three preload regressions covering decode readiness, image failures, and mobile requests. Repository checks pass. Verified desktop/mobile positioning, unchanged page height, hover playback, reduced motion, and preloaded desktop images in the browser. Full typechecking remains blocked by existing errors in ansiText.tsx and missing ansi-sequence-parser / conduit-client dependencies.

@evanpurkhiser
evanpurkhiser requested review from a team as code owners October 7, 2026 14:13
@evanpurkhiser
evanpurkhiser requested a review from a team October 7, 2026 14:13
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2026
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 2399b27 to 387129d Compare October 7, 2026 14:15
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 387129d to ec5ef29 Compare October 7, 2026 14:21
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from ec5ef29 to 9cae1b7 Compare October 7, 2026 14:24
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.68% 95.68% ±0%
Typed 142,166 142,076 🔴 -90
Untyped 6,421 6,420 🟢 -1
🔍 4 new type safety issues introduced

any-typed symbols (4 new)

File Line Detail
static/app/views/authV2/useBrandedArtworkLoading.tsx 10 MOBILE_ASSETS (var)
static/app/views/authV2/useBrandedArtworkLoading.tsx 11 DESKTOP_ASSETS (var)
static/app/views/authV2/useBrandedArtworkLoading.tsx 17 sources (var)
static/app/views/authV2/useBrandedArtworkLoading.tsx 22 pendingSources (var)

This is informational only and does not block the PR.

@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 9cae1b7 to 40ff413 Compare October 7, 2026 14:25
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 40ff413 to 73b0159 Compare October 7, 2026 14:26
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 73b0159 to 9d233e4 Compare October 7, 2026 14:32

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9d233e4. Configure here.

const hasSideArtwork = useMedia(`(min-width: ${theme.breakpoints.md})`);
const sources = hasSideArtwork ? DESKTOP_ASSETS : MOBILE_ASSETS;
const [settledSources, setSettledSources] = useState<ReadonlySet<string>>(new Set());
const isLoading = sources.some(src => !settledSources.has(src));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loader returns after breakpoint change

Medium Severity

isArtworkLoading stays tied to the current viewport asset list, so widening past md after the auth page is already shown makes sources jump to the full desktop set. BrandedAuthLayout treats that as a fresh page load, sets isLoading, and hides the form behind the full-page loader until every side-illustration image decodes.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9d233e4. Configure here.

@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 9d233e4 to 4a6a28b Compare October 7, 2026 14:59
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 4a6a28b to 58a7a67 Compare October 7, 2026 15:06
@evanpurkhiser
evanpurkhiser enabled auto-merge (squash) October 7, 2026 15:44
@evanpurkhiser
evanpurkhiser disabled auto-merge October 7, 2026 15:53
@evanpurkhiser
evanpurkhiser enabled auto-merge (squash) October 7, 2026 15:53
@evanpurkhiser
evanpurkhiser force-pushed the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch from 58a7a67 to 0c4ce27 Compare October 7, 2026 15:53
@evanpurkhiser
evanpurkhiser disabled auto-merge October 7, 2026 15:53
@evanpurkhiser
evanpurkhiser enabled auto-merge (squash) October 7, 2026 15:54
@evanpurkhiser
evanpurkhiser merged commit b61af52 into master Oct 7, 2026
71 of 72 checks passed
@evanpurkhiser
evanpurkhiser deleted the git/feat-auth-replace-branded-artwork-with-animated-illustrations branch October 7, 2026 15:59

This branch was successfully deployed

1 active deployment
Preview — 0c4ce27c Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants