Repository navigation
feat(notifications): Log every shadow comparison and widen the variant key - #126737
Merged
Merged
Conversation
…t key Log each shadow comparison as notifications.platform.shadow.result with its outcome and variant, plus flags for optional branches the legacy render took, so variant coverage is visible once comparisons start matching. Add whether the workflow links a legacy rule and whether the group is assigned to the issue alert variant, and the snuba dataset to the metric alert variant. Add matrix tests that render each provider through both paths across the branches the legacy renderers take. Co-authored-by: Cursor <cursoragent@cursor.com>
hobzcalvin
marked this pull request as draft
October 7, 2026 17:53
hobzcalvin
marked this pull request as ready for review
October 7, 2026 17:58
…iant Co-authored-by: Cursor <cursoragent@cursor.com>
shayna-ch
approved these changes
Oct 7, 2026
hobzcalvin
enabled auto-merge (squash)
October 8, 2026 17:21
hobzcalvin
disabled auto-merge
October 8, 2026 17:21
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow comparisons only logged their variant on a mismatch, so there was no way to tell which variants had actually been compared. This makes coverage visible, adds 2 more attributes/branches the variant key, and adds matrix tests that exercise every provider across those branches.
Every comparison is logged
reportnow emits onenotifications.platform.shadow.resultlog line per comparison, whatever the outcome, carryingoutcomeandvariant.Each line also flags optional branches the legacy render took that the variant doesn't name:
has_releasesandhas_chart, for all providers.has_suggested_assignees,has_replay_linkandhas_autofix_button, for Slack issue alerts. These are read from the captured Slack payload, since recomputing their inputs (ownership, suspect commits, replay counts, Seer access) would be expensive.Variant key
Issue alerts gain two parts:
rule/workflow: whether the workflow links a legacy rule. This changes the block id, the title link and the footer.assigned/unassigned: this changes the Slack assignee select and the Teams card.Matrix tests