Repository navigation
ref(auth): Remove legacy login column and join-tab styles - #126757
evanpurkhiser merged 1 commit into
Conversation
The React auth page owns the login layout. The password/social-login columns and join-request tab styles belong to the retired Django login templates; shared SAML, sudo, OAuth, and social-signup styles remain live.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ee1a323. Configure here.
| display: flex; | ||
| } | ||
|
|
||
| .auth-form-column { |
There was a problem hiding this comment.
Removed styles still used by templates
Medium Severity
Removing .auth-form-column, .auth-provider-column, and .join-request leaves live Django templates unstyled. login.html and organization-login.html still emit those classes, and AuthLoginView still renders them on routes that skip React auth, including sentry-register and sentry-auth-link-identity. Those pages lose the two-column login layout and right-aligned join tab.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit ee1a323. Configure here.
React authentication owns password login, registration, and MFA through the auth APIs. Replace the legacy login view with a React page entry point, remove its password registration and MFA forms, and delete the login, organization-login, auth-link-login, and two-factor templates. Preserve customer-domain canonicalization, the organization SSO POST pipeline, and partner/channel destination handling. Identity-link GET requests resume canonical organization login with query parameters. The legacy /auth/2fa/ route sends pending MFA back to React while preserving session state, and still completes login when the user has no authenticators. Shared SSO account-confirmation and social-signup forms, the U2F app-ID endpoint, and sudo remain in use. OAuth consent now uses canonical login via merged #126175. This incorporates the MFA cleanup from superseded #126711. The independent Vercel test update is getsentry/getsentry#22365. Follow-up frontend removals must deploy afterward: #126757 removes retired login LESS; #126761 removes the template bootstrap hook and rectangular indicator. Validation: 302 backend authentication, channel-login, MFA, and OAuth tests passed on the combined change. 172 Getsentry tests and nine subtests passed on the combined change. Affected-view type checks and pre-commit checks passed. Six browser MFA tests passed on the combined cleanup, covering TOTP, refresh/resume, incorrect codes, recovery codes, SSO with MFA, and password-reset MFA. Seven login/registration/OAuth browser tests passed on the earlier login cleanup. Browser tests used existing compiled frontend assets. The independent channel-login redirect encoding fix is tracked in #126862. Land that fix before this cleanup. Land the inactive-session reactivation fix in #126936 before this cleanup, and preserve its web-entry redirect when rebasing.


Remove the LESS for password/social-login columns and the join-request tab from the retired Django login templates, including their mobile overrides.
Land after #126712 has deployed. Kept separate from the backend removal because frontend and backend deploy independently.
Audited selector consumers across Sentry source (including provider templates) and Getsentry. Shared auth containers/footers, provider logos, org avatars, social-signup radio fields, SSO grids, and the auth-toggle used by the SAML IdP selector remain live.
Validation: the complete sentry.less entry point compiles successfully; applicable pre-commit checks passed. This deletes 65 lines from layout.less.