Skip to content

ref(auth): Remove legacy login column and join-tab styles - #126757

Merged
evanpurkhiser merged 1 commit into
masterfrom
git/ref-auth-remove-legacy-login-column-and-join-tab-styles
Oct 7, 2026
Merged

evanpurkhiser merged 1 commit into
masterfrom
git/ref-auth-remove-legacy-login-column-and-join-tab-styles

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

Remove the LESS for password/social-login columns and the join-request tab from the retired Django login templates, including their mobile overrides.

Land after #126712 has deployed. Kept separate from the backend removal because frontend and backend deploy independently.

Audited selector consumers across Sentry source (including provider templates) and Getsentry. Shared auth containers/footers, provider logos, org avatars, social-signup radio fields, SSO grids, and the auth-toggle used by the SAML IdP selector remain live.

Validation: the complete sentry.less entry point compiles successfully; applicable pre-commit checks passed. This deletes 65 lines from layout.less.

The React auth page owns the login layout. The password/social-login
columns and join-request tab styles belong to the retired Django login
templates; shared SAML, sudo, OAuth, and social-signup styles remain live.
@evanpurkhiser
evanpurkhiser requested review from billyvg and ckj October 7, 2026 19:11
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2026
@evanpurkhiser
evanpurkhiser marked this pull request as ready for review October 7, 2026 19:23
@evanpurkhiser
evanpurkhiser requested a review from a team as a code owner October 7, 2026 19:23
@evanpurkhiser
evanpurkhiser merged commit b7fdb24 into master Oct 7, 2026
70 of 71 checks passed
@evanpurkhiser
evanpurkhiser deleted the git/ref-auth-remove-legacy-login-column-and-join-tab-styles branch October 7, 2026 19:23

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee1a323. Configure here.

Comment thread static/less/layout.less
display: flex;
}

.auth-form-column {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed styles still used by templates

Medium Severity

Removing .auth-form-column, .auth-provider-column, and .join-request leaves live Django templates unstyled. login.html and organization-login.html still emit those classes, and AuthLoginView still renders them on routes that skip React auth, including sentry-register and sentry-auth-link-identity. Those pages lose the two-column login layout and right-aligned join tab.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ee1a323. Configure here.

evanpurkhiser added a commit that referenced this pull request Oct 9, 2026
React authentication owns password login, registration, and MFA through
the auth APIs. Replace the legacy login view with a React page entry
point, remove its password registration and MFA forms, and delete the
login, organization-login, auth-link-login, and two-factor templates.

Preserve customer-domain canonicalization, the organization SSO POST
pipeline, and partner/channel destination handling. Identity-link GET
requests resume canonical organization login with query parameters. The
legacy /auth/2fa/ route sends pending MFA back to React while preserving
session state, and still completes login when the user has no
authenticators. Shared SSO account-confirmation and social-signup forms,
the U2F app-ID endpoint, and sudo remain in use.

OAuth consent now uses canonical login via merged #126175. This
incorporates the MFA cleanup from superseded #126711. The independent
Vercel test update is getsentry/getsentry#22365.

Follow-up frontend removals must deploy afterward: #126757 removes
retired login LESS; #126761 removes the template bootstrap hook and
rectangular indicator.

Validation: 302 backend authentication, channel-login, MFA, and OAuth
tests passed on the combined change. 172 Getsentry tests and nine
subtests passed on the combined change. Affected-view type checks and
pre-commit checks passed. Six browser MFA tests passed on the combined
cleanup, covering TOTP, refresh/resume, incorrect codes, recovery codes,
SSO with MFA, and password-reset MFA. Seven login/registration/OAuth
browser tests passed on the earlier login cleanup. Browser tests used
existing compiled frontend assets.


The independent channel-login redirect encoding fix is tracked in
#126862. Land that fix before
this cleanup.


Land the inactive-session reactivation fix in
#126936 before this cleanup, and
preserve its web-entry redirect when rebasing.

This branch was successfully deployed

1 active deployment
Preview — ee1a3238 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants