Skip to content

fix(ci): avoid E2BIG in impacted-files oxlint step - #126758

Merged
JoshuaKGoldberg merged 4 commits into
masterfrom
joshgoldberg/de-1655-fix-oxlint-failures-when-changed-file-argument-lists-are-too
Oct 7, 2026
Merged

JoshuaKGoldberg merged 4 commits into
masterfrom
joshgoldberg/de-1655-fix-oxlint-failures-when-changed-file-argument-lists-are-too

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

The impacted-files oxlint step passed every impacted path through pnpm run lint:js, which joins them into a single sh -c string. Large impact sets overflow Linux's per-argument limit.

This invokes the oxlint wrapper directly so the paths stay separate argv entries.

Closes DE-1655.

@linear-code

linear-code Bot commented Oct 7, 2026

Copy link
Copy Markdown

DE-1655

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 7, 2026
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(ci): Avoid E2BIG in impacted-files oxlint step fix(ci): avoid E2BIG in impacted-files oxlint step Oct 7, 2026
Comment thread .github/workflows/frontend.yml Resolved
Co-authored-by: Josh Ghoulberg 👻 <github@joshuakgoldberg.com>
@JoshuaKGoldberg
JoshuaKGoldberg marked this pull request as ready for review October 7, 2026 19:23
@JoshuaKGoldberg
JoshuaKGoldberg requested a review from a team as a code owner October 7, 2026 19:23
@JoshuaKGoldberg

Copy link
Copy Markdown
Member Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0f8d135. Configure here.

@JoshuaKGoldberg
JoshuaKGoldberg enabled auto-merge (squash) October 7, 2026 20:13
@JoshuaKGoldberg
JoshuaKGoldberg merged commit 3d3e228 into master Oct 7, 2026
76 checks passed
@JoshuaKGoldberg
JoshuaKGoldberg deleted the joshgoldberg/de-1655-fix-oxlint-failures-when-changed-file-argument-lists-are-too branch October 7, 2026 20:16
JoshuaKGoldberg added a commit that referenced this pull request Oct 21, 2026
…8363)

`scripts/lint.ts` (#127203) runs root and package lint scripts through
`pnpm run`, which joins every path into one shell string, so a change to
a widely imported file makes the impacted-files oxlint step crash before
linting starts. This brings back the fix from #126758 by running each
script's command through `pnpm exec` so paths stay separate arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants