Repository navigation
fix(ci): avoid E2BIG in impacted-files oxlint step - #126758
Merged
JoshuaKGoldberg merged 4 commits intoOct 7, 2026
Merged
JoshuaKGoldberg merged 4 commits into
JoshuaKGoldberg merged 4 commits into
Conversation
Fixes DE-1655
JoshuaKGoldberg
commented
Oct 7, 2026
Co-authored-by: Josh Ghoulberg 👻 <github@joshuakgoldberg.com>
JoshuaKGoldberg
marked this pull request as ready for review
October 7, 2026 19:23
Member
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0f8d135. Configure here.
natemoo-re
approved these changes
Oct 7, 2026
…hen-changed-file-argument-lists-are-too
JoshuaKGoldberg
enabled auto-merge (squash)
October 7, 2026 20:13
JoshuaKGoldberg
deleted the
joshgoldberg/de-1655-fix-oxlint-failures-when-changed-file-argument-lists-are-too
branch
October 7, 2026 20:16
3 tasks done
JoshuaKGoldberg
added a commit
that referenced
this pull request
Oct 21, 2026
…8363) `scripts/lint.ts` (#127203) runs root and package lint scripts through `pnpm run`, which joins every path into one shell string, so a change to a widely imported file makes the impacted-files oxlint step crash before linting starts. This brings back the fix from #126758 by running each script's command through `pnpm exec` so paths stay separate arguments.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impacted-files oxlint step passed every impacted path through
pnpm run lint:js, which joins them into a singlesh -cstring. Large impact sets overflow Linux's per-argument limit.This invokes the oxlint wrapper directly so the paths stay separate argv entries.
Closes DE-1655.