Skip to content

ref(reprocessing): Optionally pass unprocessed copy inline instead of via redis - #126810

Merged
jan-auer merged 1 commit into
masterfrom
matth/reprocessing-unprocessed-inline
Oct 15, 2026
Merged

jan-auer merged 1 commit into
masterfrom
matth/reprocessing-unprocessed-inline

Conversation

@matt-codecov

@matt-codecov matt-codecov commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Removing the Redis processing store requires another way to preserve the original event payload for reprocessing.

With this change, the unprocessed copy travels inline through symbolication, processing, and save tasks into Nodestore. Redis remains the fallback when no inline copy is supplied.

Keeping store.disable-processing-store=false during deployment preserves compatibility with older workers in any rollout order. Redis backups can be disabled after all workers are updated.

@matt-codecov
matt-codecov requested review from a team as code owners October 8, 2026 00:17
@matt-codecov
matt-codecov added this pull request to stack #126812 October 8, 2026 00:17
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 8, 2026
@tobias-wilfert

Copy link
Copy Markdown
Member

Is there any linear ticket context to this?

Comment thread src/sentry/tasks/store.py
from_symbolicate=from_symbolicate,
has_attachments=has_attachments,
data=data,
unprocessed=unprocessed,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all the data in this dict JSON encodable? Tasks will fail if there are any non-json encodable values in the object.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is encodable. It contains the original data.

Comment thread src/sentry/tasks/store.py
has_attachments=has_attachments,
symbolicate_functions=symbolicate_functions,
data=data,
unprocessed=unprocessed,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should unprocessed and cache_key be mutually exclusive? I would think that the end state is that we don't have both being used as the cache key is redundant when we also have the unprocessed + data parameters present.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end state they will be mutually exclusive and eventually cache_key will be removed from the tasks. During rollout, we also double-write for some time so we can safely roll back at any point.

Comment thread src/sentry/options/defaults.py Resolved
@matt-codecov
matt-codecov force-pushed the matth/reprocessing-unprocessed-inline branch from 607e45e to dd83958 Compare October 14, 2026 23:58
@jan-auer
jan-auer merged commit 972bc39 into master Oct 15, 2026
92 checks passed
@jan-auer
jan-auer deleted the matth/reprocessing-unprocessed-inline branch October 15, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants