Repository navigation
fix(dynamic-sampling): Count SnQL Snuba errors in the per-org task status - #126830
Merged
Merged
Conversation
…atus The per-org task wrapper only caught the Snuba RPC errors, so a ClickHouse error from the SnQL outcomes query (such as a cancelled query) still raised to Sentry. Treat every SnubaError the same way and record it as the snuba_error task status. Fixes SENTRY-5XSA Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
shellmayr
marked this pull request as ready for review
October 8, 2026 11:35
vgrozdanic
approved these changes
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnubaErrorand record it as thesnuba_errortask status, the same as the RPC errors.Fixes SENTRY-5XSA