Skip to content

fix(dynamic-sampling): Count SnQL Snuba errors in the per-org task status - #126830

Merged
shellmayr merged 2 commits into
masterfrom
shellmayr/fix/ds-per-org-snuba-query-errors
Oct 8, 2026
Merged

shellmayr merged 2 commits into
masterfrom
shellmayr/fix/ds-per-org-snuba-query-errors

Conversation

@shellmayr

@shellmayr shellmayr commented Oct 8, 2026 •

Copy link
Copy Markdown
Member
  • The per-org task wrapper only caught the Snuba RPC errors.
  • A ClickHouse error from the SnQL outcomes query, such as a cancelled query, still raised to Sentry.
  • Catch every SnubaError and record it as the snuba_error task status, the same as the RPC errors.
  • Add a test for the new case.

Fixes SENTRY-5XSA

…atus

The per-org task wrapper only caught the Snuba RPC errors, so a ClickHouse
error from the SnQL outcomes query (such as a cancelled query) still raised
to Sentry. Treat every SnubaError the same way and record it as the
snuba_error task status.

Fixes SENTRY-5XSA
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 8, 2026
@shellmayr
shellmayr marked this pull request as ready for review October 8, 2026 11:35
@shellmayr
shellmayr requested a review from a team as a code owner October 8, 2026 11:35
@shellmayr
shellmayr enabled auto-merge (squash) October 8, 2026 11:46
@shellmayr
shellmayr merged commit 9e65ace into master Oct 8, 2026
68 checks passed
@shellmayr
shellmayr deleted the shellmayr/fix/ds-per-org-snuba-query-errors branch October 8, 2026 11:54

This branch was successfully deployed

1 active deployment
Preview — 8437cc44 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants