Repository navigation
feat(inbound-filters): don't allow changes on custom inbound filters without plan - #126860
Merged
Merged
Conversation
…t the plan feature The settings table showed Add Filter and the row actions on every plan, and a save then failed with the API error. The actions are now disabled with the reason, like the legacy form. Reads stay, so an organization that left the plan still sees its filters.
… plan feature Without projects:custom-inbound-filters Relay does not apply the filters and the API refuses writes. The table keeps listing them, fades every row, disables the actions, and shows the plan upsell above the list. The getsentry override copy now names custom inbound filters and says the saved filters are kept but not applied.
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
…m-filters-plan-gate
…ters page The getsentry override rendered a PanelAlert, a full-width system alert meant to sit inside a Panel. The custom filters table has no panel, so the note floated on the page without a border radius. Use the scraps Alert with the upsell button as a trailing item and drop the second documentation link. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
shellmayr
marked this pull request as ready for review
October 14, 2026 14:18
TkDodo
approved these changes
Oct 14, 2026
This was referenced Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projects:custom-inbound-filters, Business plans). Relay applies the filters only with it, and the API refuses writes without it, but the table showed every action as usable and a save then failed with the API error.