Skip to content

feat(inbound-filters): don't allow changes on custom inbound filters without plan - #126860

Merged
shellmayr merged 5 commits into
masterfrom
shellmayr/fix/custom-filters-plan-gate
Oct 15, 2026
Merged

shellmayr merged 5 commits into
masterfrom
shellmayr/fix/custom-filters-plan-gate

Conversation

@shellmayr

@shellmayr shellmayr commented Oct 8, 2026 •

Copy link
Copy Markdown
Member
  • Custom inbound filters are a plan feature (projects:custom-inbound-filters, Business plans). Relay applies the filters only with it, and the API refuses writes without it, but the table showed every action as usable and a save then failed with the API error.
  • Without the plan feature the table still lists the filters, faded like inactive ones, with Add Filter, the active toggle, edit, and delete disabled and the reason as tooltip. A plan upsell sits above the list: on SaaS the getsentry override names the plan ("available to Business plans and above") with the Learn More button, elsewhere the generic alert shows. Both say the saved filters are kept but not applied.
Screenshot 2026-10-14 at 16 17 13

…t the plan feature

The settings table showed Add Filter and the row actions on every plan, and a save then failed with the API error. The actions are now disabled with the reason, like the legacy form. Reads stay, so an organization that left the plan still sees its filters.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2026
… plan feature

Without projects:custom-inbound-filters Relay does not apply the filters and the API refuses writes. The table keeps listing them, fades every row, disables the actions, and shows the plan upsell above the list. The getsentry override copy now names custom inbound filters and says the saved filters are kept but not applied.
@shellmayr shellmayr changed the title fix(inbound-filters): Disable custom filter writes in settings without the plan feature feat(inbound-filters): List custom filters as not applied without the plan feature Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.71% 95.71% ±0%
Typed 142,132 142,140 🟢 +8
Untyped 6,364 6,365 🔴 +1
🔍 1 new type safety issue introduced

any-typed symbols (1 new)

File Line Detail
static/app/views/settings/project/projectFilters/customFilters.tsx 1047 p (param)

This is informational only and does not block the PR.

shellmayr and others added 2 commits October 14, 2026 16:01
…ters page

The getsentry override rendered a PanelAlert, a full-width system alert
meant to sit inside a Panel. The custom filters table has no panel, so the
note floated on the page without a border radius. Use the scraps Alert with
the upsell button as a trailing item and drop the second documentation link.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@shellmayr
shellmayr marked this pull request as ready for review October 14, 2026 14:18
@shellmayr
shellmayr requested review from a team as code owners October 14, 2026 14:18
@shellmayr shellmayr changed the title feat(inbound-filters): List custom filters as not applied without the plan feature feat(inbound-filters): don't allow changes on custom inbound filters without plan Oct 14, 2026
@shellmayr
shellmayr merged commit cf9af1a into master Oct 15, 2026
75 checks passed
@shellmayr
shellmayr deleted the shellmayr/fix/custom-filters-plan-gate branch October 15, 2026 06:46

This branch was successfully deployed

1 active deployment
Preview — 5e0fb8b9 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants