Skip to content

ref(replays): move the Network and Errors tables onto SimpleTable - #126864

Merged
JoshuaKGoldberg merged 10 commits into
masterfrom
joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable
Oct 9, 2026
Merged

JoshuaKGoldberg merged 10 commits into
masterfrom
joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

The Replay details > Errors and Network tables had their own virtualized div grid setup. Now they're build on a virtualized SimpleTable with a sticky header.

Adds a density='compressed' | 'default' | 'comfortable' prop to SimpleTable to match the existing denser styles (and, later, for #126889's more padded styles).

Joyously, despite adding in 105 lines to SimpleTable for density, this is still a net negative diff. It's actually +344 / -515 ignoring that.

Changed

Location Before After
Replay details › Network Replay details › Network before Replay details › Network after
Replay details › Network, details open Replay details › Network, details open before Replay details › Network, details open after
Replay details › Network, failed request Replay details › Network, failed request before Replay details › Network, failed request after
Replay details › Network, no results Replay details › Network, no results before Replay details › Network, no results after
Replay details › Errors Replay details › Errors before Replay details › Errors after
Replay details › Errors, no results Replay details › Errors, no results before Replay details › Errors, no results after

@linear-code

linear-code Bot commented Oct 8, 2026

Copy link
Copy Markdown

DE-1659

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-i8bzdfzdo.sentry.dev

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

✅ no issues found

@sentry

sentry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 620 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

The replay details Network and Errors tabs rendered their own virtualized div grid. They now render a virtualized SimpleTable with a sticky header and take on its default header, padding and row styling.

Fixes DE-1659
Also drops two explanatory comments from the replay table.

Refs DE-1659
Compressed tables tighten cell padding and drop the lines between rows. The replay Network and Errors tables use it to keep their dense rows.

Refs DE-1659
Also documents the density option in the SimpleTable stories and covers it with tests.

Refs DE-1659
The fixed columns were sized for 14px text. At 12px they fit their content and sort arrows in less room, which goes to the Path and Title columns.

Refs DE-1659
@JoshuaKGoldberg
JoshuaKGoldberg force-pushed the joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable branch from 4738ab4 to ed8a626 Compare October 8, 2026 18:27
Compressed tables now give their header row a small amount of vertical padding instead of the default 40px height, so dense lists like a replay's network requests stay close to their old header height.

Refs DE-1659

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 👌

The Network and Errors tables keep their existing cell, header and virtualization files and render them through SimpleTable, instead of replacing them with new row and header components.

Refs DE-1659

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 80bc573. Configure here.

@JoshuaKGoldberg
JoshuaKGoldberg force-pushed the joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable branch from 80bc573 to f19baf5 Compare October 8, 2026 20:10
@JoshuaKGoldberg
JoshuaKGoldberg requested a balanced review from Copilot October 8, 2026 20:11

This comment was marked as low quality.

The replay cells, rows and header cells drop styles and props that SimpleTable already provides, and the Errors tab reuses the Network tab's bordered frame and borderless table. The frame's leftover timeline rules made the Network table scroll sideways by millions of pixels while the playhead sat between two requests, so they are gone, and both tables keep scroll from chaining to the page again.

Refs DE-1659
The header and body loops map over the column configs, the jump buttons read the compressed header height directly, and the cells lose a type cast and a cell prop that FlexProps already covers. ButtonWrapper keeps isolating TimestampButton from the flex cell without its no-op style.

Refs DE-1659
…9-move-the-replay-network-and-errors-tables-onto-simpletable

# Conflicts:
#	static/app/components/replays/virtualizedGrid/headerCell.tsx
@JoshuaKGoldberg JoshuaKGoldberg changed the title ref(tables): move the replay Network and Errors tables onto SimpleTable ref(replays): move the Network and Errors tables onto SimpleTable Oct 9, 2026
@JoshuaKGoldberg
JoshuaKGoldberg merged commit a9d9024 into master Oct 9, 2026
97 of 99 checks passed
@JoshuaKGoldberg
JoshuaKGoldberg deleted the joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable branch October 9, 2026 14:02
JoshuaKGoldberg added a commit that referenced this pull request Oct 9, 2026
Table header labels clip their content so they can truncate it. But that
also cuts off the focus rings in header cells.

The header cells and label now leave room for a focus ring around their
content using the old "2px + -2px" margin/padding trick.

Some interesting context / explaining why this is in a stack:

* This has to be stacked on #126864 because replay tables were using the
header cells in funky ways.
* This wasn't an issue until #126794. That's the first interactive
content in a `SimpleTable` header cell (that I know of).
* #126889 needs to be stacked on #126864 in some way to use its
`density` prop

Closes DE-1678.

This branch was successfully deployed

1 active deployment
Preview — 8d8ea504 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants