Repository navigation
ref(replays): move the Network and Errors tables onto SimpleTable - #126864
Merged
JoshuaKGoldberg merged 10 commits intoOct 9, 2026
Conversation
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-i8bzdfzdo.sentry.dev |
Contributor
📊 Type Coverage Diff✅ no issues found |
Contributor
Sentry Snapshot Testing
|
The replay details Network and Errors tabs rendered their own virtualized div grid. They now render a virtualized SimpleTable with a sticky header and take on its default header, padding and row styling. Fixes DE-1659
Also drops two explanatory comments from the replay table. Refs DE-1659
Compressed tables tighten cell padding and drop the lines between rows. The replay Network and Errors tables use it to keep their dense rows. Refs DE-1659
Also documents the density option in the SimpleTable stories and covers it with tests. Refs DE-1659
The fixed columns were sized for 14px text. At 12px they fit their content and sort arrows in less room, which goes to the Path and Title columns. Refs DE-1659
JoshuaKGoldberg
force-pushed
the
joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable
branch
from
October 8, 2026 18:27
4738ab4 to
ed8a626
Compare
Compressed tables now give their header row a small amount of vertical padding instead of the default 40px height, so dense lists like a replay's network requests stay close to their old header height. Refs DE-1659
The Network and Errors tables keep their existing cell, header and virtualization files and render them through SimpleTable, instead of replacing them with new row and header components. Refs DE-1659
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 80bc573. Configure here.
JoshuaKGoldberg
force-pushed
the
joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable
branch
from
October 8, 2026 20:10
80bc573 to
f19baf5
Compare
The replay cells, rows and header cells drop styles and props that SimpleTable already provides, and the Errors tab reuses the Network tab's bordered frame and borderless table. The frame's leftover timeline rules made the Network table scroll sideways by millions of pixels while the playhead sat between two requests, so they are gone, and both tables keep scroll from chaining to the page again. Refs DE-1659
The header and body loops map over the column configs, the jump buttons read the compressed header height directly, and the cells lose a type cast and a cell prop that FlexProps already covers. ButtonWrapper keeps isolating TimestampButton from the flex cell without its no-op style. Refs DE-1659
…9-move-the-replay-network-and-errors-tables-onto-simpletable # Conflicts: # static/app/components/replays/virtualizedGrid/headerCell.tsx
JoshuaKGoldberg
deleted the
joshgoldberg/de-1659-move-the-replay-network-and-errors-tables-onto-simpletable
branch
October 9, 2026 14:02
JoshuaKGoldberg
added a commit
that referenced
this pull request
Oct 9, 2026
Table header labels clip their content so they can truncate it. But that also cuts off the focus rings in header cells. The header cells and label now leave room for a focus ring around their content using the old "2px + -2px" margin/padding trick. Some interesting context / explaining why this is in a stack: * This has to be stacked on #126864 because replay tables were using the header cells in funky ways. * This wasn't an issue until #126794. That's the first interactive content in a `SimpleTable` header cell (that I know of). * #126889 needs to be stacked on #126864 in some way to use its `density` prop Closes DE-1678.
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The Replay details > Errors and Network tables had their own virtualized div grid setup. Now they're build on a virtualized
SimpleTablewith a sticky header.Adds a
density='compressed' | 'default' | 'comfortable'prop toSimpleTableto match the existing denser styles (and, later, for #126889's more padded styles).Joyously, despite adding in 105 lines to SimpleTable for
density, this is still a net negative diff. It's actually +344 / -515 ignoring that.Changed