Skip to content

feat(ci): add sherif to validate dependencies - #126892

Merged
TkDodo merged 1 commit into
masterfrom
tkdodo/feat/add-sherif
Oct 8, 2026
Merged

TkDodo merged 1 commit into
masterfrom
tkdodo/feat/add-sherif

Conversation

@TkDodo

@TkDodo TkDodo commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

sherif makes sure all packages in the monorepo have the same version. We currently don't have violations, just some mismatches between ^ dependencies and strict dependencies, which are also fixed here.

it runs in CI and during pre-commit when a package.json, pnpm-workspace.yaml, or pnpm-lock.yaml changes

sherif makes sure all packages in the monorepo have the same version. We currently don't have violations, just some mismatches between ^ dependencies and strict dependencies, which are also fixed here.

it runs in CI and during pre-commit when a package.json, pnpm-workspace.yaml, or pnpm-lock.yaml changes
@TkDodo

TkDodo commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

bugbot run

@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3aec9a9. Configure here.

@TkDodo
TkDodo marked this pull request as ready for review October 8, 2026 16:18
@TkDodo
TkDodo requested review from a team as code owners October 8, 2026 16:18
@TkDodo
TkDodo requested review from a team and natemoo-re October 8, 2026 16:19
Comment thread package.json Resolved
@TkDodo
TkDodo merged commit f3a6e19 into master Oct 8, 2026
76 checks passed
@TkDodo
TkDodo deleted the tkdodo/feat/add-sherif branch October 8, 2026 16:53

This branch was successfully deployed

1 active deployment
Preview — 3aec9a9a Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants