Skip to content

fix(tests): Set the workflow environment in the shadow variant matrix - #126925

Merged
kenzoengineer merged 3 commits into
masterfrom
fix/shadow-matrix-workflow-env
Oct 8, 2026
Merged

kenzoengineer merged 3 commits into
masterfrom
fix/shadow-matrix-workflow-env

Conversation

@kenzoengineer

@kenzoengineer kenzoengineer commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

The matrix set workflow_env without giving the Workflow an environment. After #126617 the platform path takes the environment from workflow_env while the legacy Slack path still reads Workflow.environment_id, so the env cases mismatched. Create the workflow with the environment and derive workflow_env from it, matching production.

The matrix set workflow_env without giving the Workflow an environment. After
#126617 the platform path takes the environment from workflow_env while the
legacy Slack path still reads Workflow.environment_id, so the env cases
mismatched. Create the workflow with the environment and derive workflow_env
from it, matching production.

Co-Authored-By: Ken Jiang <ken.jiang@sentry.io>
@kenzoengineer
kenzoengineer requested a review from a team as a code owner October 8, 2026 18:17
@kenzoengineer
kenzoengineer enabled auto-merge (squash) October 8, 2026 18:20
@sentry

sentry Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 612 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

@kenzoengineer
kenzoengineer disabled auto-merge October 8, 2026 18:58
@kenzoengineer
kenzoengineer enabled auto-merge (squash) October 8, 2026 18:58
@kenzoengineer
kenzoengineer merged commit 2a5d390 into master Oct 8, 2026
63 checks passed
@kenzoengineer
kenzoengineer deleted the fix/shadow-matrix-workflow-env branch October 8, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants