Skip to content

ref(profiling): move the call tree table onto SimpleTable - #126976

Merged
JoshuaKGoldberg merged 12 commits into
masterfrom
joshgoldberg/de-1665-move-the-profiling-call-tree-table-onto-simpletable
Oct 15, 2026
Merged

JoshuaKGoldberg merged 12 commits into
masterfrom
joshgoldberg/de-1665-move-the-profiling-call-tree-table-onto-simpletable

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

The profiling call tree in the flamegraph drawer and aggregate flamegraph is now one virtualized SimpleTable treegrid with sticky weight columns, replacing the two synced div grids and ghost rows. useVirtualizedTree now scrolls to a revealed frame after the expanded tree renders, which is what lets a table be its scroll container.

This adds (7 + 190 + 98 + 14 + 48) = 357 lines of tests, so in a sense it's kind of a +607/-1001 diff. 🔪

Changed

Location Before After
Transaction profile › drawer call tree, expanded Transaction profile drawer expanded before Transaction profile drawer expanded after
Transaction profile › drawer call tree, selected row Transaction profile drawer selected before Transaction profile drawer selected after
Transaction profile › drawer call tree, context menu Transaction profile drawer context menu before Transaction profile drawer context menu after
Transaction profile › drawer call tree, narrow Transaction profile drawer narrow before Transaction profile drawer narrow after
Continuous profile › drawer call tree, expanded Continuous profile drawer expanded before Continuous profile drawer expanded after
Continuous profile › drawer call tree, selected row Continuous profile drawer selected before Continuous profile drawer selected after
Continuous profile › drawer call tree, context menu Continuous profile drawer context menu before Continuous profile drawer context menu after
Continuous profile › drawer call tree, narrow Continuous profile drawer narrow before Continuous profile drawer narrow after
Profiling › Aggregate Flamegraph › Call Tree, expanded Profiling aggregate call tree expanded before Profiling aggregate call tree expanded after
Profiling › Aggregate Flamegraph › Call Tree, selected row Profiling aggregate call tree selected before Profiling aggregate call tree selected after
Profiling › Aggregate Flamegraph › Call Tree, context menu Profiling aggregate call tree context menu before Profiling aggregate call tree context menu after
Profiling › Aggregate Flamegraph › Call Tree, narrow Profiling aggregate call tree narrow before Profiling aggregate call tree narrow after
Transaction summary › Profiles › Call Tree, expanded Transaction summary call tree expanded before Transaction summary call tree expanded after
Transaction summary › Profiles › Call Tree, selected row Transaction summary call tree selected before Transaction summary call tree selected after
Transaction summary › Profiles › Call Tree, context menu Transaction summary call tree context menu before Transaction summary call tree context menu after
Transaction summary › Profiles › Call Tree, narrow Transaction summary call tree narrow before Transaction summary call tree narrow after
Issue details › View Hierarchy, after selecting a wireframe node View hierarchy before View hierarchy after

Closes DE-1665.

The flamegraph drawer and aggregate flamegraph call trees render as one virtualized SimpleTable treegrid with sticky weight columns. useVirtualizedTree now scrolls to a revealed node after the expanded tree commits instead of resizing its scroll container's first child.

Fixes DE-1665
@linear-code

linear-code Bot commented Oct 8, 2026

Copy link
Copy Markdown

DE-1665

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-5cy00ynrx.sentry.dev

…able-onto-simpletable

# Conflicts:
#	static/app/components/profiling/flamegraph/aggregateFlamegraphTreeTable.tsx
#	static/app/components/profiling/flamegraph/callTreeTable.tsx
#	static/app/components/profiling/flamegraph/flamegraphDrawer/flamegraphTreeTable.tsx
#	static/app/components/tables/simpleTable/index.spec.tsx
#	static/app/components/tables/simpleTable/index.tsx
The call tree uses SimpleTable's compressed density instead of its own cell padding, and the sticky weight columns shrink to fit the smaller header text.

Refs DE-1665
The weight column headers go back to master's left-aligned labels with the sort arrow on the right.

Refs DE-1665
Leaves room for long durations and sample counts next to the percentage and frame icon.

Refs DE-1665
The SimpleTable migration dropped the yellow200 bottom border that master draws under the weight bars.

Refs DE-1665
@JoshuaKGoldberg
JoshuaKGoldberg marked this pull request as ready for review October 9, 2026 18:22
@JoshuaKGoldberg
JoshuaKGoldberg requested review from a team as code owners October 9, 2026 18:22

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Hovered rows get master's tertiary background again, and pointer row lookups on the table account for its border and sticky header.

Refs DE-1665
Arrow-key navigation only scrolls sideways when the selected row's indent is out of view, so it no longer undoes a user's horizontal scroll.

Refs DE-1665
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 95.72% 95.73% 🟢 +0.01%
Typed 142,184 142,147 🔴 -37
Untyped 6,364 6,347 🟢 -17
🔍 2 new type safety issues introduced

Type assertions (as) (2 new)

File Line Detail
static/app/utils/profiling/hooks/useVirtualizedTree/useVirtualizedTree.tsx 405 as HTMLElement — evt.target as HTMLElement
static/app/utils/profiling/hooks/useVirtualizedTree/useVirtualizedTree.tsx 434 as HTMLElement — evt.target as HTMLElement

This is informational only and does not block the PR.

The SimpleTable migration dropped the border-right that master draws after the weight columns. The header dividers are turned off so they don't double up against the restored borders.

Refs DE-1665
The SimpleTable migration rendered the expand toggle as a 24px icon button, which pushed frame names 16px further right than on master. A link-variant button sizes to its 12px chevron and keeps master's muted color.

Refs DE-1665
Renders the expand toggle as master's rotated › glyph in a 10px box at the row text color, and restores the 2px corner radius on the frame color square.

Refs DE-1665

@mjq mjq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…5-move-the-profiling-call-tree-table-onto-simpletable

# Conflicts:
#	static/app/components/tables/simpleTable/index.spec.tsx
@JoshuaKGoldberg
JoshuaKGoldberg enabled auto-merge (squash) October 15, 2026 13:33
@JoshuaKGoldberg
JoshuaKGoldberg merged commit 76bff7e into master Oct 15, 2026
80 checks passed
@JoshuaKGoldberg
JoshuaKGoldberg deleted the joshgoldberg/de-1665-move-the-profiling-call-tree-table-onto-simpletable branch October 15, 2026 13:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 44594e8. Configure here.

[props.rowHeight, onScrollToNode, props.scrollContainer, theme]
);
);
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reveal may jump the page

Medium Severity

handleScrollTo now calls onScrollToNode after the expanded tree commits, so the target row is usually already rendered. View hierarchy then takes the scrollIntoView branch instead of scrolling only its own container. That can pan ancestor page scrollers when the 700px widget is only partly on screen, which the old scrollBy path did not do.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 44594e8. Configure here.

This branch was successfully deployed

1 active deployment
Preview — 44594e88 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants