Repository navigation
ref(profiling): move the call tree table onto SimpleTable - #126976
JoshuaKGoldberg merged 12 commits into
Conversation
The flamegraph drawer and aggregate flamegraph call trees render as one virtualized SimpleTable treegrid with sticky weight columns. useVirtualizedTree now scrolls to a revealed node after the expanded tree commits instead of resizing its scroll container's first child. Fixes DE-1665
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-5cy00ynrx.sentry.dev |
…able-onto-simpletable # Conflicts: # static/app/components/profiling/flamegraph/aggregateFlamegraphTreeTable.tsx # static/app/components/profiling/flamegraph/callTreeTable.tsx # static/app/components/profiling/flamegraph/flamegraphDrawer/flamegraphTreeTable.tsx # static/app/components/tables/simpleTable/index.spec.tsx # static/app/components/tables/simpleTable/index.tsx
The call tree uses SimpleTable's compressed density instead of its own cell padding, and the sticky weight columns shrink to fit the smaller header text. Refs DE-1665
The weight column headers go back to master's left-aligned labels with the sort arrow on the right. Refs DE-1665
Leaves room for long durations and sample counts next to the percentage and frame icon. Refs DE-1665
The SimpleTable migration dropped the yellow200 bottom border that master draws under the weight bars. Refs DE-1665
Hovered rows get master's tertiary background again, and pointer row lookups on the table account for its border and sticky header. Refs DE-1665
Arrow-key navigation only scrolls sideways when the selected row's indent is out of view, so it no longer undoes a user's horizontal scroll. Refs DE-1665
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
The SimpleTable migration dropped the border-right that master draws after the weight columns. The header dividers are turned off so they don't double up against the restored borders. Refs DE-1665
The SimpleTable migration rendered the expand toggle as a 24px icon button, which pushed frame names 16px further right than on master. A link-variant button sizes to its 12px chevron and keeps master's muted color. Refs DE-1665
Renders the expand toggle as master's rotated › glyph in a 10px box at the row text color, and restores the 2px corner radius on the frame color square. Refs DE-1665
…5-move-the-profiling-call-tree-table-onto-simpletable # Conflicts: # static/app/components/tables/simpleTable/index.spec.tsx
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44594e8. Configure here.
| [props.rowHeight, onScrollToNode, props.scrollContainer, theme] | ||
| ); | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Reveal may jump the page
Medium Severity
handleScrollTo now calls onScrollToNode after the expanded tree commits, so the target row is usually already rendered. View hierarchy then takes the scrollIntoView branch instead of scrolling only its own container. That can pan ancestor page scrollers when the 700px widget is only partly on screen, which the old scrollBy path did not do.
Reviewed by Cursor Bugbot for commit 44594e8. Configure here.


The profiling call tree in the flamegraph drawer and aggregate flamegraph is now one virtualized
SimpleTabletreegrid with sticky weight columns, replacing the two synced div grids and ghost rows.useVirtualizedTreenow scrolls to a revealed frame after the expanded tree renders, which is what lets a table be its scroll container.This adds (7 + 190 + 98 + 14 + 48) = 357 lines of tests, so in a sense it's kind of a +607/-1001 diff. 🔪
Changed
Closes DE-1665.