Repository navigation
chore(✂️): Check Scraps and icons workspaces - #127008
Merged
Merged
Conversation
TkDodo
commented
Oct 9, 2026
Collaborator
Author
There was a problem hiding this comment.
keeping these icons even though they have no usage
| 'static/packages/icons': { | ||
| // Keep Knip's default coverage; test helpers are only used outside production. | ||
| project: ['**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}!', '!test/**!'], | ||
| includeEntryExports: true, |
Collaborator
Author
There was a problem hiding this comment.
includeEntryExports lets us check usages across the monorepo. This is how we found the unused icons. Would love to turn this on for scraps too but we currently have a lot of things exported that are unused. We’d need to figure out if we want to keep them exported or if we mark them as public or delete them.
TkDodo
marked this pull request as ready for review
October 9, 2026 10:30
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-osa3e71yu.sentry.dev |
Jesse-Box
approved these changes
Oct 9, 2026
This was referenced Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knip now checks the Scraps and icons workspaces instead of ignoring them. It also checks unused exports in icon entry points and no longer treats every app icon as a production entry point. Test helpers and package verification scripts are excluded from production unused-file checks.
Icons kept for future use are marked
@public. Six icons and their package exports are removed, andIconSizeis kept private to its module. The Button story usesIconAddandIconSubtractfor zoom controls, matching the app, soIconZoomcan be removed.