Skip to content

feat(timeseries): Decode indexed transformations query parameters - #127057

Merged
nsdeschenes merged 1 commit into
masterfrom
nd/feat/exp-1302-transformations-decoder
Oct 15, 2026
Merged

nsdeschenes merged 1 commit into
masterfrom
nd/feat/exp-1302-transformations-decoder

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Add in a function to decode new transformations query param on /events-timeseries/ into ordered string lists keyed by the requested yAxis position.

Example: transformations[0]=fill(locf)&transformations[0]=smooth(sma) decodes to {0: ["fill(locf)", "smooth(sma)"]}.

Validate indexed keys and axis bounds before query execution when explore-interpolation-and-smoothing is enabled. Function strings remain opaque.

Function validation and application are tracked separately in EXP-1279.

Closes EXP-1302.

Decode ordered strings by axis position under the existing feature flag.

Refs EXP-1302
@linear-code

linear-code Bot commented Oct 9, 2026

Copy link
Copy Markdown

EXP-1302

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2026
@nsdeschenes nsdeschenes changed the title feat(explore): Decode indexed transformations query parameters feat(timeseries): Decode indexed transformations query parameters Oct 9, 2026
@nsdeschenes

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3a2c363. Configure here.

else:
return None

def get_transformations(self, request: Request) -> dict[int, list[str]]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be anywhere else we'd like to get transformations? Thinking if it would make sense to make this a broader util so other endpoints could use this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point no, there are not plans to expand this beyond events-timeseries, and we're actually migrating all of dashboards to be based off of events-timeseries, as it is the defacto standard for any EAP timeseries related data.

@adrianviquez adrianviquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, otherwise lgtm

except ValueError:
raise ParseError(detail="Invalid transformations index")
if index >= axis_count:
raise ParseError(detail="transformations index must match a yAxis position")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you capitalized the other errors, so in case you want to do the same for this one for consistency

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not capitalized because transformations is the raw query param that's being passed from the URL.

@nsdeschenes
nsdeschenes merged commit 9990179 into master Oct 15, 2026
80 checks passed
@nsdeschenes
nsdeschenes deleted the nd/feat/exp-1302-transformations-decoder branch October 15, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants