Repository navigation
test(notifications): Use origins for notification identity - #127085
Merged
Merged
Conversation
kcons
force-pushed
the
ref/notification-origin-only-interfaces
branch
from
October 9, 2026 18:55
4653fd0 to
5ba0945
Compare
kcons
force-pushed
the
ref/notification-origin-only-interfaces
branch
2 times, most recently
from
October 9, 2026 23:00
f38298b to
b5097ed
Compare
kcons
force-pushed
the
ref/notification-origin-only-interfaces
branch
3 times, most recently
from
October 14, 2026 18:59
d422466 to
2b343ce
Compare
kcons
marked this pull request as ready for review
October 14, 2026 19:33
leeandher
approved these changes
Oct 14, 2026
kcons
force-pushed
the
ref/notification-origin-only-interfaces
branch
from
October 14, 2026 20:33
6461a65 to
d504816
Compare
kcons
force-pushed
the
ref/notification-origin-only-interfaces
branch
from
October 14, 2026 21:08
d504816 to
a4aebb5
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification tests now source workflow and legacy rule IDs from NotificationOrigin or NotificationActionContext instead of reaching into serialized rule action data.
This updates builder payload, digest, webhook, mail, and origin-resolution coverage to use the typed notification boundary. Direct action-data manipulation remains only where we're testing legacy ID normalization.