Skip to content

test(notifications): Use origins for notification identity - #127085

Merged
kcons merged 2 commits into
masterfrom
ref/notification-origin-only-interfaces
Oct 14, 2026
Merged

kcons merged 2 commits into
masterfrom
ref/notification-origin-only-interfaces

Conversation

@kcons

@kcons kcons commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Notification tests now source workflow and legacy rule IDs from NotificationOrigin or NotificationActionContext instead of reaching into serialized rule action data.

This updates builder payload, digest, webhook, mail, and origin-resolution coverage to use the typed notification boundary. Direct action-data manipulation remains only where we're testing legacy ID normalization.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2026
@kcons
kcons force-pushed the ref/notification-origin-only-interfaces branch from 4653fd0 to 5ba0945 Compare October 9, 2026 18:55
@kcons
kcons added this pull request to stack #126600 October 9, 2026 19:00
@kcons
kcons force-pushed the ref/notification-origin-only-interfaces branch 2 times, most recently from f38298b to b5097ed Compare October 9, 2026 23:00
Base automatically changed from ref/remove-render-rule-compat to master October 13, 2026 19:39
@kcons
kcons force-pushed the ref/notification-origin-only-interfaces branch 3 times, most recently from d422466 to 2b343ce Compare October 14, 2026 18:59
@github-actions github-actions Bot removed the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
@kcons kcons changed the title ref(notifications): Require notification origins in builders test(notifications): Use origins for notification identity Oct 14, 2026
@kcons
kcons marked this pull request as ready for review October 14, 2026 19:33
@kcons
kcons requested review from a team as code owners October 14, 2026 19:33
@kcons
kcons force-pushed the ref/notification-origin-only-interfaces branch from 6461a65 to d504816 Compare October 14, 2026 20:33
@kcons
kcons force-pushed the ref/notification-origin-only-interfaces branch from d504816 to a4aebb5 Compare October 14, 2026 21:08
@kcons
kcons merged commit 2fd318d into master Oct 14, 2026
65 checks passed
@kcons
kcons deleted the ref/notification-origin-only-interfaces branch October 14, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants