Repository navigation
fix(issues): Stop the seerDrawer redirect from looping on the autofix tab - #127123
Merged
Merged
Conversation
… tab Legacy `?seerDrawer=true` links crash issue details with "Maximum update depth exceeded" when `autofix-page` is on. The drawer effect called `openSeerDrawer`, which navigates to the autofix tab, but it read `seerDrawer` from nuqs. Since the nuqs bump in #127078, nuqs syncs router navigations in a transition, so the value stays `true` for a few renders. Every navigation recreated the callback, reran the effect, and navigated again. The redirect is now a `<Navigate replace>` that reads the router location, so it renders once. The drawer effect only opens the drawer for orgs without `autofix-page` and never navigates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
marked this pull request as ready for review
October 9, 2026 23:14
ryan953
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy
?seerDrawer=truelinks crash issue details with "Maximum update depth exceeded" whenautofix-pageis on. The redirect lived in an effect that navigated while readingseerDrawerfrom nuqs, and since #127078 nuqs syncs router navigations in a transition, so the value stayed stale and every navigation reran the effect.Moves the redirect to a
<Navigate replace>keyed on the router location, and the drawer effect no longer navigates.fixes JAVASCRIPT-3DQB
fixes JAVASCRIPT-3B0Z