Skip to content

fix(notifications): Remove Rule support in URL generation - #127127

Merged
kcons merged 2 commits into
masterfrom
kcons/noruleurl
Oct 13, 2026
Merged

kcons merged 2 commits into
masterfrom
kcons/noruleurl

Conversation

@kcons

@kcons kcons commented Oct 9, 2026

Copy link
Copy Markdown
Member

We shouldn't be handing out rule URLs anymore, and we don't need to.

@kcons
kcons requested review from a team as code owners October 9, 2026 23:49
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 9, 2026
@kcons

kcons commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Actually, gonna wait on #126791, which makes this change simpler.

@kcons
kcons marked this pull request as draft October 9, 2026 23:50
@kcons
kcons marked this pull request as ready for review October 13, 2026 17:55
@kcons
kcons requested a review from a team October 13, 2026 17:55
@kcons kcons changed the title fix(notifications): Delete build_rule_url fix(notifications): Remove Rule support in URL generation Oct 13, 2026
event: GroupEvent | None = None,
tags: set[str] | None = None,
rules: Sequence[Rule | NotificationOrigin] | None = None,
rules: Sequence[NotificationOrigin] | None = None,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think slowly but surely i'm getting more confused about places where we write rule but actually mean NotificationOrigin. don't really think its a problem right now but might be worth changing at some point?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%. I've got a very big "stop calling things 'rule'" PR coming, I've just been avoiding those renames in incremental PRs to avoid making the diffs bigger than the actual changes merit.

@kcons

kcons commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

bugbot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0b02572. Configure here.

@kcons
kcons merged commit cc17ceb into master Oct 13, 2026
71 checks passed
@kcons
kcons deleted the kcons/noruleurl branch October 13, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants