Repository navigation
fix(notifications): Remove Rule support in URL generation - #127127
Conversation
|
Actually, gonna wait on #126791, which makes this change simpler. |
478f193 to
0b02572
Compare
| event: GroupEvent | None = None, | ||
| tags: set[str] | None = None, | ||
| rules: Sequence[Rule | NotificationOrigin] | None = None, | ||
| rules: Sequence[NotificationOrigin] | None = None, |
There was a problem hiding this comment.
i think slowly but surely i'm getting more confused about places where we write rule but actually mean NotificationOrigin. don't really think its a problem right now but might be worth changing at some point?
There was a problem hiding this comment.
100%. I've got a very big "stop calling things 'rule'" PR coming, I've just been avoiding those renames in incremental PRs to avoid making the diffs bigger than the actual changes merit.
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0b02572. Configure here.
We shouldn't be handing out rule URLs anymore, and we don't need to.