Repository navigation
fix(github): align webhook secret check with GHE - #127191
Merged
giovanni-guidini merged 1 commit intoOct 13, 2026
Merged
Conversation
The `github-app.webhook-secret` option defaults to an empty string, which the handler didn't treat as missing. Reject any falsy secret, matching the GitHub Enterprise webhook behavior. Fixes SCM-223 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Current version of PR was reviewed by /review-bugbot on Oct 12, 14:18 GMT+2. It flagged 0 findings. Bugbot on commit |
vaind
approved these changes
Oct 13, 2026
giovanni-guidini
deleted the
gio/fix/reject-empty-github-webhook-secret
branch
October 13, 2026 08:04
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
github-app.webhook-secretoption defaults to an empty string, which the handler didn't treat as missing. Reject any falsy secret, matching the GitHub Enterprise webhook behavior.Fixes SCM-223