Skip to content

fix(github): align webhook secret check with GHE - #127191

Merged
giovanni-guidini merged 1 commit into
masterfrom
gio/fix/reject-empty-github-webhook-secret
Oct 13, 2026
Merged

giovanni-guidini merged 1 commit into
masterfrom
gio/fix/reject-empty-github-webhook-secret

Conversation

@giovanni-guidini

Copy link
Copy Markdown
Contributor

The github-app.webhook-secret option defaults to an empty string, which the handler didn't treat as missing. Reject any falsy secret, matching the GitHub Enterprise webhook behavior.

Fixes SCM-223

The `github-app.webhook-secret` option defaults to an empty string, which the
handler didn't treat as missing. Reject any falsy secret, matching the GitHub
Enterprise webhook behavior.

Fixes SCM-223
Co-Authored-By: Claude <noreply@anthropic.com>
@giovanni-guidini
giovanni-guidini requested review from a team as code owners October 12, 2026 12:42
@linear-code

linear-code Bot commented Oct 12, 2026

Copy link
Copy Markdown

SCM-223

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 12, 2026
@cursor

cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Current version of PR was reviewed by /review-bugbot on Oct 12, 14:18 GMT+2. It flagged 0 findings.

Bugbot on commit 1a1616b is skipped.

@giovanni-guidini
giovanni-guidini merged commit a6d0323 into master Oct 13, 2026
68 checks passed
@giovanni-guidini
giovanni-guidini deleted the gio/fix/reject-empty-github-webhook-secret branch October 13, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants