Skip to content

ref(flags): Remove organizations:issue-stream-recommended-sort gates (frontend) - #127209

Merged
roggenkemper merged 1 commit into
masterfrom
claude-rm-issue-stream-recommended-sort
Oct 14, 2026
Merged

roggenkemper merged 1 commit into
masterfrom
claude-rm-issue-stream-recommended-sort

Conversation

@cursor

@cursor cursor Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Remove the frontend reads of organizations:issue-stream-recommended-sort. This flag was fully rolled out in the automator in PR #8428 on 6/30/26 (GA segment, rollout: 100, conditions: []) and hasn't been touched since, so Recommended is always an available sort option.

The two hasRecommendedSort checks were <this flag> || <...-default> || <active sort is Recommended>. Collapsing the first term to true makes the other two unreachable, so the whole predicate goes away and IssueSortOptions.RECOMMENDED is always in the list.

organizations:issue-stream-recommended-sort-default and ...-experimental are separate, still-live flags: -default still gates whether Recommended is the default sort in overview.tsx, and both registrations are untouched here.

Verified locally: pnpm run typecheck clean, 187 tests pass across static/app/views/issueList/, oxlint + oxfmt clean.

Part of a 3-PR cleanup, merge first. Follow-ups remove the automator value, then the registration in temporary.py.

Open in Web View Automation 

…(frontend)

The flag reached GA (rollout 100%, no conditions) in sentry-options-automator
#8428 on 2026-06-30, so Recommended is always an available sort option.

Collapsing the first term of each hasRecommendedSort check to true makes the
remaining -default and active-sort terms unreachable, so they go too. The
-default flag still gates whether Recommended is the *default* sort in
overview.tsx; that reader and both sibling registrations are untouched.

Co-authored-by: charlie.luo <charlie.luo@sentry.io>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 12, 2026
@cursor
cursor Bot marked this pull request as ready for review October 12, 2026 20:40
@cursor
cursor Bot requested a review from a team as a code owner October 12, 2026 20:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getsentry/issues-feed @getsentry/issue-detection-frontend — stale-flag cleanup for organizations:issue-stream-recommended-sort (CODEOWNERS of static/app/views/issueList/; flagpole owner.team: issue_detection). This is the frontend half.

Merge order (3 PRs):

  1. this PR — removes the two frontend reads
  2. getsentry/sentry-options-automator#10141 — removes the flagpole value
  3. #127210 — removes the registration in temporary.py, merge last

The one judgment call worth reviewing: both call sites were hasRecommendedSort = <this flag> || <...-sort-default> || <active sort is Recommended>. Since this flag is GA for every org, the whole predicate is true, which makes the other two terms unreachable — so they go too and IssueSortOptions.RECOMMENDED is now unconditionally in sortKeys. Removing only the first term would have left -default || active, which is narrower than today's behavior. Shout if you'd rather keep the predicate as an explicit const hasRecommendedSort = true.

...-sort-default and ...-sort-experimental are separate flags and are untouched: -default still gates the default-sort/localStorage behavior in overview.tsx, and -experimental still has its backend readers.

Verified locally: pnpm run typecheck clean, all 187 tests in static/app/views/issueList/ pass with no spec changes needed, oxlint + oxfmt clean.

CI: 46 green, 1 red — the red is the usual getsentry dispatch gate, which fails because the author (cursor[bot]) has no write permission. A collaborator needs to add the Trigger: getsentry tests label.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Feature flag cleanup

@roggenkemper roggenkemper added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Oct 14, 2026
@roggenkemper
roggenkemper merged commit 76b483d into master Oct 14, 2026
87 of 88 checks passed
@roggenkemper
roggenkemper deleted the claude-rm-issue-stream-recommended-sort branch October 14, 2026 14:31
roggenkemper pushed a commit that referenced this pull request Oct 14, 2026
…127210)

Remove the registration of `organizations:issue-stream-recommended-sort`
from `temporary.py`. This flag was fully rolled out in the automator in
PR #8428 on 6/30/26 (GA segment, `rollout: 100`, `conditions: []`) and
hasn't been touched since.

Step 3 of 3, **merge last**: the frontend reads are removed by #127209
and the automator value by getsentry/sentry-options-automator#10141.
Merging this before those land would make `organization.features` drop
the flag while the UI still reads it, hiding the Recommended sort option
until #127209 deploys.

The `...-default` and `...-experimental` siblings are separate,
still-live flags and stay registered.

<div><a
href="https://cursor.com/agents/bc-0022944d-a6ae-4bd6-b615-0fa636824997?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/b02055f4-b602-11f1-bb68-864e54d14197"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: charlie.luo <charlie.luo@sentry.io>
adrianviquez pushed a commit that referenced this pull request Oct 14, 2026
…127210)

Remove the registration of `organizations:issue-stream-recommended-sort`
from `temporary.py`. This flag was fully rolled out in the automator in
PR #8428 on 6/30/26 (GA segment, `rollout: 100`, `conditions: []`) and
hasn't been touched since.

Step 3 of 3, **merge last**: the frontend reads are removed by #127209
and the automator value by getsentry/sentry-options-automator#10141.
Merging this before those land would make `organization.features` drop
the flag while the UI still reads it, hiding the Recommended sort option
until #127209 deploys.

The `...-default` and `...-experimental` siblings are separate,
still-live flags and stay registered.

<div><a
href="https://cursor.com/agents/bc-0022944d-a6ae-4bd6-b615-0fa636824997?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/automations/b02055f4-b602-11f1-bb68-864e54d14197"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/view-automation-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/view-automation-light.png"><img
alt="View Automation" width="141" height="28"
src="https://cursor.com/assets/images/view-automation-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: charlie.luo <charlie.luo@sentry.io>

This branch was successfully deployed

1 active deployment
Preview — f63209f0 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants