Repository navigation
fix(ci): Cache node_modules of all packages - #127219
Merged
Merged
Conversation
Cache root and workspace node_modules with bounded globs to avoid pnpm symlink archive conflicts. Include runner architecture, workspace settings, and the root package manifest in cache keys.
TkDodo
marked this pull request as ready for review
October 13, 2026 08:18
obostjancic
approved these changes
Oct 13, 2026
priscilawebdev
approved these changes
Oct 13, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI cache task needs to store all
node_modulesof all packages to properly restore them, and the cache key needs to know aboutrunner.arch, as we have different architectures apparently which means some optional peerDeps might be missing in an install.