Repository navigation
feat(sdk): Use data_collection instead of send_default_pii - #127229
Conversation
… query parameters in order to comply with GDPR.
| "terms": ["forwarded", "-ip", "remote-", "via", "-user"], | ||
| } | ||
| }, | ||
| "cookies": {"mode": "denylist", "terms": ["forwarded", "-ip", "remote-", "via", "-user"]}, |
There was a problem hiding this comment.
Why don't we flatout deny cookies? Don't recall us using these in any way
There was a problem hiding this comment.
I have no objections, happy to turn this completely off for cookies if we don't use them.
For context on why this was introduced in the first place: the default behaviour in data collection is a denylist but which doesn't automatically filter some terms that may have been filtered previously (see the Extended Deny Terms section of the spec), so I thought this needed to be added at a minimum for GDPR compliance reasons.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e6fc64. Configure here.

send_default_piiis deprecated and will be removed in SDK 3.0, coming soon.