Skip to content

feat(sdk): Use data_collection instead of send_default_pii - #127229

Merged
sentrivana merged 3 commits into
masterfrom
ivana/data-collection
Oct 14, 2026
Merged

sentrivana merged 3 commits into
masterfrom
ivana/data-collection

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

send_default_pii is deprecated and will be removed in SDK 3.0, coming soon.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026
… query parameters

in order to comply with GDPR.
@sentrivana
sentrivana marked this pull request as ready for review October 13, 2026 10:56
@sentrivana
sentrivana requested review from a team as code owners October 13, 2026 10:56
Comment thread src/sentry/conf/server.py Outdated
"terms": ["forwarded", "-ip", "remote-", "via", "-user"],
}
},
"cookies": {"mode": "denylist", "terms": ["forwarded", "-ip", "remote-", "via", "-user"]},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we flatout deny cookies? Don't recall us using these in any way

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, happy to turn this completely off for cookies if we don't use them.

For context on why this was introduced in the first place: the default behaviour in data collection is a denylist but which doesn't automatically filter some terms that may have been filtered previously (see the Extended Deny Terms section of the spec), so I thought this needed to be added at a minimum for GDPR compliance reasons.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e6fc64. Configure here.

Comment thread src/sentry/conf/server.py Resolved
@sentrivana
sentrivana merged commit 2e421ec into master Oct 14, 2026
87 checks passed
@sentrivana
sentrivana deleted the ivana/data-collection branch October 14, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants