Repository navigation
ref(integrations): Default max_retries to zero - #127255
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85aec8d. Configure here.
markstory
approved these changes
Oct 13, 2026
markstory
left a comment
Member
There was a problem hiding this comment.
Makes sense to me. Using an option is a great idea.
wedamija
approved these changes
Oct 13, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

requests.adapters.HTTPAdapterhandles themax_retriesparameter like so:The
DEFULAT_RETRIESconstant is set to0at the top of the file. The condition is falsey when specified asNoneand setsmax_retriesto the result ofRetry.from_int(None). Importingurllib3and inspecting the output reveals the following:This is clearly not the intent of
max_retries=None. We should explicitly coerceNoneto0. This presents as four botched connections to a slow service as seen here: https://sentry.sentry.io/explore/traces/trace/261e7f32d8374953a95768436e6f61d2?node=span-b8c91fc7944e2287. The control silo will hold the process open for the 40 second duration (10s per connection). However, the cell silo has already closed its connection after its 10 second timeout. Meaning even if these requests did resolve they would have not been able to return anyway.I'm only applying this change to the base client because its the one actually reaching out to GitHub et al. Proxy clients are still allowed to retry.