Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sentry/api/endpoints/organization_events_validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Any, TypedDict

from drf_spectacular.utils import extend_schema
from rest_framework.exceptions import ParseError
from rest_framework.exceptions import ParseError, PermissionDenied
from rest_framework.request import Request
from rest_framework.response import Response
from sentry_protos.snuba.v1.trace_item_attribute_pb2 import AttributeKey
Expand Down Expand Up @@ -198,6 +198,10 @@ def get(
Validation(valid=False, error="At least one valid project is required to query")
)
return self.serialize_response(response)
except PermissionDenied:
response["valid"] = False
response["projects"].append(Validation(valid=False, error="Invalid project"))
return self.serialize_response(response)
except UnknownEnvironments as error:
response["valid"] = False
response["environment"].append(Validation(valid=False, error=str(error)))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ def test_no_projects(self) -> None:
{"error": "At least one valid project is required to query", "valid": False}
]

def test_invalid_project(self) -> None:
other_project = self.create_project(organization=self.create_organization())
response = self.do_request({"project": [other_project.id]})

assert response.status_code == 400, response.content
assert not response.data["valid"]
assert response.data["projects"] == [{"error": "Invalid project", "valid": False}]

def test_invalid_dataset(self) -> None:
response = self.do_request(
{
Expand Down
Loading