Repository navigation
ref(metrics): Remove the SENTRY_METRICS_SKIP_ALL_INTERNAL default - #127271
Merged
Starrao123 merged 1 commit intoOct 13, 2026
Merged
Starrao123 merged 1 commit into
Starrao123 merged 1 commit into
Conversation
#126989 stopped reading this setting, and getsentry/getsentry#22474 removed the last assignments to it, so nothing needs the default. Refs INFRENG-723
Starrao123
marked this pull request as ready for review
October 13, 2026 17:09
valencitas
approved these changes
Oct 13, 2026
ldelvoye
reviewed
Oct 13, 2026
ldelvoye
left a comment
Member
There was a problem hiding this comment.
🌱 Looked through this, no blocking issues.
This review was generated by a bot; every message tagged 🌱 is from it. Reply with bot: to ask it something.
Starrao123
deleted the
vinayakrao/infreng-723-remove-metrics-skip-all-internal-default
branch
October 13, 2026 17:28
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs INFRENG-723
Nothing reads or sets
SENTRY_METRICS_SKIP_ALL_INTERNALanymore. #126989 stopped reading it, and getsentry/getsentry#22474 removed the last assignments to it. This removes the default that was kept only for getsentry'stest_prod_settings.Tests: getsentry's
tests/getsentry/test_settings.pypasses locally against this change.