Skip to content

ref(metrics): Remove the SENTRY_METRICS_SKIP_ALL_INTERNAL default - #127271

Merged
Starrao123 merged 1 commit into
masterfrom
vinayakrao/infreng-723-remove-metrics-skip-all-internal-default
Oct 13, 2026
Merged

Starrao123 merged 1 commit into
masterfrom
vinayakrao/infreng-723-remove-metrics-skip-all-internal-default

Conversation

@Starrao123

Copy link
Copy Markdown
Contributor

Refs INFRENG-723

Nothing reads or sets SENTRY_METRICS_SKIP_ALL_INTERNAL anymore. #126989 stopped reading it, and getsentry/getsentry#22474 removed the last assignments to it. This removes the default that was kept only for getsentry's test_prod_settings.

Tests: getsentry's tests/getsentry/test_settings.py passes locally against this change.

#126989 stopped reading this setting, and
getsentry/getsentry#22474 removed the last assignments to it, so nothing
needs the default.

Refs INFRENG-723
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

INFRENG-723

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026
@Starrao123
Starrao123 marked this pull request as ready for review October 13, 2026 17:09
@Starrao123
Starrao123 requested a review from a team as a code owner October 13, 2026 17:09
@Starrao123
Starrao123 requested a review from a team October 13, 2026 17:09

@ldelvoye ldelvoye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Looked through this, no blocking issues.

This review was generated by a bot; every message tagged 🌱 is from it. Reply with bot: to ask it something.

@Starrao123
Starrao123 merged commit 8ba76b9 into master Oct 13, 2026
88 checks passed
@Starrao123
Starrao123 deleted the vinayakrao/infreng-723-remove-metrics-skip-all-internal-default branch October 13, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants