Repository navigation
build(ui): Keep chunk hashes stable across deploys - #127286
Merged
Merged
Conversation
The getsentry overrides load on every page, and the Seer quota sidebar override was imported eagerly. It renders autofix, which pulls in the Seer markdown embeds, which pull in the chart embed and echarts. That one import was about half of the startup JS. Load it with `lazy()` like the other heavy overrides. Its only caller is the issue details sidebar, which already has the autofix code loaded, so the new chunk is tiny. startup JS goes from 2.19 MB to 1.30 MB gzipped, echarts no longer loads on every page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
echarts, zrender and echarts-for-react load on almost every page. Without a named group they land in whatever chunk rspack builds from the chunk sets that use them, and that grouping shifts as app code changes. Pin them to a single `echarts` chunk so its hash only changes when we upgrade echarts. 280K gzipped, nothing else in it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bundler plugin was prepending `SENTRY_RELEASE={id:"<sha>"}` to every
chunk. The commit sha changes every deploy, so every chunk hash changed
too and everyone re-downloaded all of the JS, even code that didn't change.
The SDK already sets `release` from the build env or the server config, so
the injected global wasn't used.
two builds of the same code with different releases went from 1,784 of
1,787 chunks renamed to 0
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reverts the lazy load from 854d647, leaving that for a separate change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
marked this pull request as ready for review
October 13, 2026 19:03
ryan953
reviewed
Oct 13, 2026
| maxAsyncRequests: 10, // (default: 30) | ||
| cacheGroups: localeChunkGroups, | ||
| cacheGroups: { | ||
| ...localeChunkGroups, |
Member
There was a problem hiding this comment.
is localeChunkGroups used anywhere else?
Member
There was a problem hiding this comment.
ah, seems not. but it's locale-specific. cool cool
Member
Author
There was a problem hiding this comment.
yeah that handles splitting the locales into lazy chunks
ryan953
approved these changes
Oct 13, 2026
3 tasks done
3 of 5 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentry bundler plugin was adding
SENTRY_RELEASE={id:"<commit sha>"}to the top of every chunk. Since the sha changes every deploy, every chunk got a new hash and everyone re-downloaded all of the JS even when nothing in it changed. We already passreleasetoSentry.init, so the injected value wasn't used. This turns injection off.Also moves echarts, zrender and echarts-for-react into their own
echartschunk so it only changes when we upgrade echarts.