Repository navigation
fix(webhooks): Stop using Rule in get_triggering_rule_name - #127308
Conversation
Christinarlong
left a comment
There was a problem hiding this comment.
🙌 so does this change the webhook payload significantly? I think we included references to rule ids? or alert ids in them?
This just changes what we call the rule, sadly. Some (sentry_app I believe) webhooks still do publish a Rule.id where available, and Workflow.id when not. That's weird, but the most obvious path forward there is probably just passing along the Workflow.id, but I need to look into who may be using that id first, because if folks are depending on it externally we may need to have a serious think on how much we're willing to break things vs maintain legacy ids indefinitely. |
Falling back to Rule may or may not provide a better message, but since Rules aren't maintained anymore, we shouldn't be exposing their data.