Skip to content

fix(webhooks): Stop using Rule in get_triggering_rule_name - #127308

Merged
kcons merged 1 commit into
masterfrom
kcons/noback
Oct 13, 2026
Merged

kcons merged 1 commit into
masterfrom
kcons/noback

Conversation

@kcons

@kcons kcons commented Oct 13, 2026

Copy link
Copy Markdown
Member

Falling back to Rule may or may not provide a better message, but since Rules aren't maintained anymore, we shouldn't be exposing their data.

@kcons
kcons requested review from a team as code owners October 13, 2026 20:35
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026

@Christinarlong Christinarlong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 so does this change the webhook payload significantly? I think we included references to rule ids? or alert ids in them?

@kcons

kcons commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

🙌 so does this change the webhook payload significantly? I think we included references to rule ids? or alert ids in them?

This just changes what we call the rule, sadly. Some (sentry_app I believe) webhooks still do publish a Rule.id where available, and Workflow.id when not. That's weird, but the most obvious path forward there is probably just passing along the Workflow.id, but I need to look into who may be using that id first, because if folks are depending on it externally we may need to have a serious think on how much we're willing to break things vs maintain legacy ids indefinitely.

@kcons
kcons merged commit 00450fe into master Oct 13, 2026
68 checks passed
@kcons
kcons deleted the kcons/noback branch October 13, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants