Skip to content

fix(locking): prefix lock release errors with an error code - #127334

Merged
ldelvoye merged 1 commit into
masterfrom
ldelvoye/fix/lock-release-error-codes
Oct 14, 2026
Merged

ldelvoye merged 1 commit into
masterfrom
ldelvoye/fix/lock-release-error-codes

Conversation

@ldelvoye

Copy link
Copy Markdown
Member

resolves INFRENG-740

Starts the two lock-release error replies in delete_lock.lua with NOLOCK and LOCKHELD.

Redis and Valkey count error replies under the first word of the message, so these currently show up in errorstats as NO and LOCK, which reads as noise on the Valkey dashboard. Both callers only log the message; nothing parses it.

Redis and Valkey file error replies under the first word of the
message, so these showed up in errorstats as NO and LOCK.
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

INFRENG-740

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026
@ldelvoye
ldelvoye requested a review from a team October 13, 2026 23:28

@ldelvoye ldelvoye left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Looked through this, no blocking issues.

This review was generated by a bot; every message tagged 🌱 is from it. Reply with bot: to ask it something.

@markstory markstory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The return value of this script isn't used anywhere so it won't have any runtime impact. The first word being used for metrics aligns with the documentation of error_reply as well.

@ldelvoye
ldelvoye merged commit c619e16 into master Oct 14, 2026
65 checks passed
@ldelvoye
ldelvoye deleted the ldelvoye/fix/lock-release-error-codes branch October 14, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants