Repository navigation
fix(locking): prefix lock release errors with an error code - #127334
Merged
Merged
Conversation
Redis and Valkey file error replies under the first word of the message, so these showed up in errorstats as NO and LOCK.
Starrao123
approved these changes
Oct 13, 2026
ldelvoye
commented
Oct 13, 2026
ldelvoye
left a comment
Member
Author
There was a problem hiding this comment.
🌱 Looked through this, no blocking issues.
This review was generated by a bot; every message tagged 🌱 is from it. Reply with bot: to ask it something.
markstory
approved these changes
Oct 14, 2026
markstory
left a comment
Member
There was a problem hiding this comment.
Looks good to me. The return value of this script isn't used anywhere so it won't have any runtime impact. The first word being used for metrics aligns with the documentation of error_reply as well.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves INFRENG-740
Starts the two lock-release error replies in
delete_lock.luawithNOLOCKandLOCKHELD.Redis and Valkey count error replies under the first word of the message, so these currently show up in errorstats as
NOandLOCK, which reads as noise on the Valkey dashboard. Both callers only log the message; nothing parses it.