Repository navigation
fix(issues): Validate update bodies before reading discard - #127342
Merged
Merged
Conversation
yuvmen
marked this pull request as ready for review
October 13, 2026 23:54
scttcper
approved these changes
Oct 14, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue updates with a JSON
nullor another non-object body now return HTTP 400 instead of 500. Readdiscardafter the sharedGroupValidatorhas validated the request, allowing its existing validation errors to reach the client on both the legacy and organization-scoped routes.Regression tests cover invalid bodies and accepted empty bodies on both routes. All five targeted tests, including existing resolve and discard tests, pass; prek also passes.
Resolves ID-1925.