Skip to content

fix(issues): Validate update bodies before reading discard - #127342

Merged
yuvmen merged 1 commit into
masterfrom
codex/fix-issue-update-validation
Oct 14, 2026
Merged

yuvmen merged 1 commit into
masterfrom
codex/fix-issue-update-validation

Conversation

@yuvmen

@yuvmen yuvmen commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Issue updates with a JSON null or another non-object body now return HTTP 400 instead of 500. Read discard after the shared GroupValidator has validated the request, allowing its existing validation errors to reach the client on both the legacy and organization-scoped routes.

Regression tests cover invalid bodies and accepted empty bodies on both routes. All five targeted tests, including existing resolve and discard tests, pass; prek also passes.

Resolves ID-1925.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026
@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

ID-1925

@yuvmen
yuvmen marked this pull request as ready for review October 13, 2026 23:54
@yuvmen
yuvmen requested review from a team as code owners October 13, 2026 23:54
@yuvmen
yuvmen merged commit 4ee9c92 into master Oct 14, 2026
74 of 75 checks passed
@yuvmen
yuvmen deleted the codex/fix-issue-update-validation branch October 14, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants